If a feed provides a file ( i.e. in temp directory) which actually does not exists there will be an error thrown by FeedsEnclosure::getFile()
called in filefield_feeds_set_target()
. This error won't be caught until
FeedsNodeProcessor::process()
. The result is that the feed-item with an invalid filename won't be imported at all.
Using feeds to migrate for example old websites its very likely that some referenced files aren't available any more. I'd prefer to import the item anyway but without the referenced file.
See also: #926616: FeedsEnclosure::getFile() should allow files to exist in the temp directory
Comment | File | Size | Author |
---|---|---|---|
#1 | feeds-invalid-enclosure-2237201-1.patch | 1.62 KB | osopolar |
Comments
Comment #1
osopolarI would prefer proceed with importing the feed item but with leaving a message in watchdog by catching the error in filefield_feeds_set_target().
Comment #2
osopolarComment #3
osopolarComment #5
osopolarfailed testing seems not to be related to this patch
Comment #8
MegaChriz CreditAttribution: MegaChriz commentedIn most cases, patches should be tested against dev.
Comment #10
twistor CreditAttribution: twistor commented