API page: https://api.drupal.org/api/drupal/includes%21common.inc/function/entity_...

The api page for this call does not have a Returns entry

CommentFileSizeAuthor
#5 2235969-5.patch542 bytesandrei.dincu
#3 drupal7-2235969-3.patch474 bytesRajendar Reddy
#1 2235969-1.patch523 bytesandrei.dincu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andrei.dincu’s picture

andrei.dincu CreditAttribution: andrei.dincu commented
Status: Active » Needs review
FileSize
2235969-1.patch523 bytes

@return
* An array of an entity type.

Status: Needs review » Needs work

The last submitted patch, 1: 2235969-1.patch, failed testing.

Rajendar Reddy’s picture

Rajendar Reddy CreditAttribution: Rajendar Reddy commented
Status: Needs work » Needs review
FileSize
drupal7-2235969-3.patch474 bytes

Rerolling the patch. Please review.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work 
+ * @return
+ *   An array of an entity type.
+ *

Ummmm... This doesn't really tell me anything useful, and it's a bit confusing?

andrei.dincu’s picture

andrei.dincu CreditAttribution: andrei.dincu commented
Status: Needs work » Needs review
FileSize
2235969-5.patch542 bytes

Added extra info for return value.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

OK, that's better! But it's information about an entity *type*, not an entity, right? And we should probably document that if it's all types, what the array keys are, etc.