I have noticed while migration that there exists theme function in sub modules for grouping the fields. Personally i don't like that for two reasons:
1.) Template file (tpl.php) based approach is much cleaner and that is the future.
2.) It could be handled by Field Group

Field Group has a nice api which accepts "suggestions", so its not hardcoded. It could be overridden in ui as well as my favorite - could be exported using features.

What do you think guys?

Comments

juliangb’s picture

juliangb CreditAttribution: juliangb commented

Would this be possible as an optional dependency rather than mandatory?

D34dMan’s picture

D34dMan CreditAttribution: D34dMan commented

Yes. All we need to do is implement a hook. No explicit function call required.

juliangb’s picture

juliangb CreditAttribution: juliangb commented

I'm in favour of this then.

I use field group on a couple of sites and it works quite well.

juliangb’s picture

juliangb CreditAttribution: juliangb commented

Is there a specific patch that will go against this issue, or will it be incorporated into other changes?

(Just wondering if we can close this issue to clean up the queue?)

D34dMan’s picture

D34dMan CreditAttribution: D34dMan commented

Field group support incorporation is already going into the field migration. I was quite annoyed at the broken state ( as it looked ) after the fields where migrated.

So yes, you may please close this issue as the question have been addressed in #3

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Active » Fixed

Great. I saw that you've committed some support for it to the feature/pmperson branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Closed (fixed) » Active

@D34dMan What would you think about using vertical tabs instead of fieldsets?

(I'm not greatly fussed either way, but thought it might help make those pages cleaner).

I've been working with the feature/pmperson branch quite a bit this afternoon.

D34dMan’s picture

D34dMan CreditAttribution: D34dMan commented

For official support:
Yes, tabs would be better at organising contents and making it look cleaner. Should we create a different vertical tab group or reuse the existing one ( which drupal provides ).

----

On unofficial lines.
I am not a fan of tabs when it comes to forms presenting related information. It tends to hide the information from the user. Making visual summary impossible at one glance.

This is why i use Fieldgroup Table. I am ready to give support in for field group table theming in PM Vista since its something i would use.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

@D34dMan
What is the status of this issue, and is there anything else that needs to happen before it is closed as fixed?

D34dMan’s picture

D34dMan CreditAttribution: D34dMan commented
Status: Active » Closed (fixed)

this can be closed. Field Group support is already there in 2.x branch and is an optional dependency.