How to reproduce
* Use a view with many arguments and some rewrites
* Bump your head when your reach the 256-char-limit

(The idea to workaround this by first doing the rewrite in a rewrite field does not work. The subview will get only one argument, it looks like argument splitting is done before token substitution.)

CommentFileSizeAuthor
#2 views_field_view-2233819-2.patch989 bytesdructor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geek-merlin’s picture

I think 1024 chars is more appropriate.

dructor’s picture

Status: Active » Needs review
FileSize
989 bytes

Converted arguments field from textfield to textarea, eliminating the length limit

geek-merlin’s picture

Status: Needs review » Reviewed & tested by the community

Applies and fixes the issue.

damiankloip’s picture

Status: Reviewed & tested by the community » Needs work

Sorry, I don't think we should have a textarea. I think the initial patch is ok?

geek-merlin’s picture

Status: Needs work » Reviewed & tested by the community

I've worked with this a lot now and IF you have some long rewrites it's a holy pain to only have a textfield.
So i strongly support that approach. Can you elaborate your objections?

damiankloip’s picture

So rtbc but we're still discussing it? Ok :) I am not totally against a textarea. I just don't see many cases you would need this much space. What sort of tokens are you passing in there? Do you have examples?

If we do go with a text are a maybe we limit the rows.

geek-merlin’s picture

>If we do go with a text are a maybe we limit the rows.
Maybe even to 1 so freaks like me can still expand...

Exapmple use case (from several the one simplest to explain):
Content type with currently 15 (and growing) key fields that are handed to a "matching items" sub-view.

damiankloip’s picture

OK. Fair enough if you are passing that many arguments to a child view. Seems like something is architecturally wrong in that case though... But Meh. Let's go with a the text area with one or two rows?