Updated: Comment #N
Problem/Motivation
When an issue has a lot of comments, it takes considerable effort to find out who has been the most involved and who might have the most knowledge about the issue.
Proposed resolution
Add a list of commenters' usernames to the issue page with the number of their comments, ordered descending by the comment number. The number of uploaded patches and the number of status changes could be interesting too, but then it should rather be a table instead of a simple list.
Possibilities:
1) use a view or sql query to generate the data
- would this slow the page load? if so, I think we should not.
2) use javascript to get the info that is already on the page
Remaining tasks
- discuss
- implement https://drupal.org/contribute/drupalorg/code (Contribute to Drupal.org Code changes document)
- review
User interface changes
The list should take place in the sidebar below the "Jump to" menu, and it should be collapsed by default to avoid clutter.
API changes
None.
Related Issues
- https://github.com/dreditor/dreditor/issues/116 "add a participant list button like create commit message button"
Comment | File | Size | Author |
---|---|---|---|
#15 | out.tsv_.gz | 228.72 KB | drumm |
#6 | team.png | 409.9 KB | YesCT |
#4 | names.txt | 1.71 KB | YesCT |
#4 | blockwstats.txt | 2.81 KB | YesCT |
#4 | justnames.png | 306.98 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedadd related dreditor issue
Comment #2
markhalliwellA simple list of the number of comments wouldn't be that hard to implement.
However, I must argue that has little to no context as to the value of the comments.
It'd be interesting if we could add the string length (minus entire code blocks and html markup) could play into this? For example:
User A adds 3 comments, each a few paragraphs long.
User B adds 15 comments, each a single sentence (sometimes to explain their status changes or a simple yes/no to questions).
User C adds 1 comment, a novel really. They spent a lot of time thinking about the issue and/or have valuable insight to the issue at hand.
Which user really has "knowledge" about the issue? Relying on a list that simply uses "# of comments" isn't very reliable IMO.
Comment #3
csg CreditAttribution: csg commentedThere is no perfect method for this, but one long comment means you have spent time thinking on the issue only once, while a lot of short comments means you have been following the issue's progress for a while. I still think it is a better indicator.
Comment #4
YesCT CreditAttribution: YesCT commentedtxt files are html that can just be inserted into an issue page.
But, I think it might actually be easier to mock this up using dreditor and javascript.. but here are two terrible starts.
Based on this little trial, a table is probably best, if the data could be in there, and js could sort it client side.
people with stats
(let me be the first to say: ick, and sortable table would be better)
just people
The simple version.
(I think this might work better styled to be a comma separated list that runs all together and not each on its own line.)
---
And I think both should be collapsed by default (but I didn't make them that way)
Comment #5
markhalliwellJust some notes (to keep track here):
Comment #6
YesCT CreditAttribution: YesCT commentedThe collapsed by default was a way to encourage this to not be a leader board, or have people game this.
For similar (social/political) reasons, I would not be comfortable limiting it to Top X Participants.
Practically, though, I dont just want to know who is knowlegable... I want to know who is interested *at all*. Someone who comments once, might be an untapped resource, and we might be able to encourage them, and point them to other places they could help with.
A person who is commenting 20 times on an issue, is probably pretty busy. Someone who comments once... might have some time open to take on another issue.
We do not exclude people who commented 3 or few times from the d8mi team ...
---
Summary: some people might find this useful to identify people knowledgable in an issue or area, some people might use it to identify people with untapped potential, and others might use this in ways we haven't thought of yet.
So I think we should include everyone.
Comment #7
YesCT CreditAttribution: YesCT commentedI think clicking on their name and having it go to their most recent comment is a sane thing to do.
The other idea I had, was that it would hide comments by others, and only show comments by that person... but that might be weird.
Comment #8
YesCT CreditAttribution: YesCT commentedfrom irc, markcarver commented:
I think that was in support of the data coming from a query, but I'm not sure.
Comment #9
Bojhan CreditAttribution: Bojhan commentedI am quite unsure about the added value of this, we already have a lot of information in the sidebars. I am not sure about filling it up with this.
Comment #10
drummThis should also be tested with smaller issues. Most issues do not have a huge list of commenters. We shouldn't over-optimize for huge issues.
Comment #11
YesCT CreditAttribution: YesCT commentedDo we have data? For closed (fixed) issues, do we know how many people commented? average, median.
Comment #12
YesCT CreditAttribution: YesCT commented@Bojhan Yeah, that is why I was thinking it could be collapsed.
An alternative could be to put it (still collapsed) at the end of the issue.
@drumm This could be a very good one to try out in dreditor first to get a feel for if it is useful and how it is useful.
Comment #13
YesCT CreditAttribution: YesCT commentedComment #14
YesCT CreditAttribution: YesCT commentedlink in summary to how to do things on d.o
Comment #15
drummSome data on Closed (fixed) issues:
Median doesn't seem straightforward in SQL, so the results of the inner query are attached.
(In general, dev sites are good for designing/writing queries, so anyone with staging access can run the queries on staging/production with a full data set, and not need to think about writing the SQL. https://drupal.org/node/1018084)
Comment #16
YesCT CreditAttribution: YesCT commentedThis is kind of "done" with the new credit UI that is exposed to all people. #2295411: Auto-generate Git attribution info / commit messages on Drupal.org
Do we want to keep it open for something else we show on the actual page and not part as a form (that is in a field that most people might keep collapsed)?
Comment #17
YesCT CreditAttribution: YesCT commentedah, #2232393: Add the option to the issue search form to return the list of commenters instead of issues should still be of value though.