Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This adds support for the video_embed_field module (hopefully!)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | field_conditional_state-video-embed-field-2229797-5.patch | 1.43 KB | Tobias Xy |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #2
Tobias Xy CreditAttribution: Tobias Xy commentedYou also have to add an entry to _field_conditional_state_get_field_states (which states can be applied to the video field) and _field_conditional_state_get_trigger_states (which states can be triggered by the video field). :-)
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedThanks for checking it out, Tobias. It's basically a textfield (it accepts a URL for a video embed and an optional description), so currently it's using the default behaviour for both functions. Should I add a case for this field?
BTW love this module ^^
Comment #4
Tobias Xy CreditAttribution: Tobias Xy commentedThe default behavior is "no supported states", so for each supported widget must exist an explicit statement within these two functions, what states are supported. (When applying your patch you won't be able to create states involving a video embed field).
I'm glad that you like it and that you're contributing to it!
Comment #5
Tobias Xy CreditAttribution: Tobias Xy commentedComment #6
Tobias Xy CreditAttribution: Tobias Xy commentedComment #7
IWasBornToWin CreditAttribution: IWasBornToWin commentedHow about image field? Video field? Or will file field work?
Comment #8
Tobias Xy CreditAttribution: Tobias Xy commentedYou can see the already supported fields on the front page. If you want to have support for a field not listed there, create a new feature request for it (unless there isn't already an issue for the widget).
Comment #10
Tobias Xy CreditAttribution: Tobias Xy commentedDone.
But: The description field of video_embed_field isn't affected by enabled/required states. We have to fix #2228243: Allow multiple form elements as state target first and I don't know if including the description field into these states makes sense anyway.