The current validation on the domain alias admin form prevents extending domain alias with additional fields without completely duplicating the validation, because if the current method does not detect any change, it throws a form error. Attached is a patch which changes the validation to allow "no changes" to pass through. It also changes the reporting when changes do occur to be more explicit.

Examples of new status messages:
Alias Created: "Alias example.org created."
Alias Removed: "Alias example.org removed."
Alias Updated: "Alias example.org updated."

If you change multiple aliases, multiple messages are displayed:

  • Alias example.com created.
  • Alias example.org removed.
CommentFileSizeAuthor
domain-alias-dont-throw-error-in-validation-for-no-change.patch8.48 KBbradyemerson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented
Status: Active » Postponed (maintainer needs more info)

Do you have code to test this behavior with?

bradyemerson’s picture

bradyemerson CreditAttribution: bradyemerson commented

I don't see test files for domain_alias, can you point me in the correct direction if there are existing ones? I've functionally tested this change via the Domain interface in Drupal admin.