Problem/Motivation

It shouldnt be the role of the ui in views to decide the markup wrappers around each field.

Proposed resolution

move the markup out in views-view-field.html.twig where it belongs

Remaining tasks

- remove the style settings from fields
- add default markup to views-view-field.html.twig

User interface changes

API changes

Comments

mortendk’s picture

Title: remove the ui markup selector from views field, use views-view-field.html.twig instead » remove the ui markup selector from views field, use views-view-field.html.twig
Issue summary: View changes
euphoric_mv’s picture

Assigned: Unassigned » euphoric_mv
euphoric_mv’s picture

I have a few questions:

  1. Do I need to remove whole style settings from Views UI for fields or just for wrapper?
  2. This settings are reflected on views-view-fields.html.twig, not on views-view-field.html.twig. Do I need to add default markup to views-view-field.html.twig or views-view-fields.html.twig file?
  3. Why we are doing this? I think, from site-builders point of view, it is good to have this style settings in views

Thanks.

penyaskito’s picture

Are we sure that we want this? What about the experience of site builders who are used to change their views output via UI?

Manuel Garcia’s picture

Issue tags: +Views dreammarkup
Manuel Garcia’s picture

Issue tags: -Views dreammarkup +VDC
dead_arm’s picture

Removing this markup is a huge functionality regression. It isn't just 'themers' who use this to control markup, but also site builders who may not want to go into the theme and adjust things with twig.

The views ui was introduced to cut back on the amount of markup you have to write yourself. It doesn't prevent you from doing so if you desire, but we shouldn't be removing things with belief that this sort of stuff is backwards.

dawehner’s picture

Status: Active » Closed (won't fix)

Removing this markup is a huge functionality regression. It isn't just 'themers' who use this to control markup, but also site builders who may not want to go into the theme and adjust things with twig.

The views ui was introduced to cut back on the amount of markup you have to write yourself. It doesn't prevent you from doing so if you desire, but we shouldn't be removing things with belief that this sort of stuff is backwards.

So true! Thank you to get a rational and filled with arguments answer!!

It shouldnt be the role of the ui in views to decide the markup wrappers around each field.

You don't want it to be there, but a lot of other people really want it to be there. It is THE functionality people really like about views.