Greetings,

By default getid3 path is built from module path and one more '/getid3' folder.

function getid3_get_path() {
  return variable_get('getid3_path', drupal_get_path('module', 'getid3') .'/getid3');
}

When visiting settings page after enabling module it says getid3 lib is not found and the path is 'modules/getid3/getid3' which is correct.

Here is the reason - you are adding one more superfluous folder '/getid3/getid3.php':

function _getid3_admin_settings_check_path($form_element) {
  $path = $form_element['#value'];
  if (!is_dir($path) || !file_exists($path .'/getid3/getid3.php')) {
  ......

You probably have to change it to:

  ......
  if (!is_dir($path) || !file_exists($path .'/getid3.php')) {
  ......
CommentFileSizeAuthor
#20 getid3_222666.patch8.83 KBdrewish
#10 getid3.2008.10.30.patch1.61 KBjmcclelland
#1 getid3.patch1.18 KBRobLoach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Version: 5.x-1.1 » 5.x-1.x-dev
Status: Active » Needs review
FileSize
getid3.patch1.18 KB

Does this do it?

guardian’s picture

guardian CreditAttribution: guardian commented

not sure the patch works
i get no more error message, however i get this: Version GETID3_VERSION found.

asb’s picture

asb CreditAttribution: asb commented

Hi Rob,

same here; the patch applies cleanly, admin/settings/getid3 reports "Version GETID3_VERSION found" when saving the setting. The former error message ("The getID3 PHP library could not be found in modules/getid3/getid3") is gone, but the getid3 library still seems not to be found, at least according to the warning when a mediafield node is bing saved ("getid3 library not found!").

Greetings, -asb

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Title: getid3 lib default path is wrong » GetID3 lib default path is wrong
Status: Needs review » Needs work
drew reece’s picture

drew reece CreditAttribution: drew reece commented

Bump,

Having the same trouble with the 5.x-1.1 version

Also seems to be a related issue here?
http://drupal.org/node/265969

Drew

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs work » Needs review

The issue with mediafield not finding getid3 at a given path is an issue with mediafield, not with this module. Mediafield has a static requirement for the path and does not depend on or utilize this module. I'd submit that to the mediafield people.

Testing patch.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

I applied the patch and set my custom path to misc/lib/getid3/ (which is the location required by mediafield). This resolved the issue for me. I'd recommend those trying to use both mediafield and modules that depend on this one try that and re-test the patch.

To use both mediafield and modules that depend on this one:

  1. Apply the patch: http://drupal.org/files/issues/getid3.patch.
  2. Put the whole getid3 library in drupalroot/misc/lib/getid3/ (there will be misc/lib/getid3/getid3 inside this directory among other things; don't let that confuse you).
  3. At admin/settings/getid3, set the path to misc/lib/getid3/ and save.
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

Whoops, sorry for changing your status; didn't realize you were the maintainer.

I do think the patch is OK, though. :P The only concern might be that the constant GETID3_VERSION wasn't interpreted properly for asb. It does work alright for me; I get Version 1.7.7 found.

jmcclelland’s picture

jmcclelland CreditAttribution: jmcclelland commented

Thanks for the patch. It works for me against version 5. I also get the correct version reported (Version 1.7.7).

jmcclelland’s picture

jmcclelland CreditAttribution: jmcclelland commented
FileSize
getid3.2008.10.30.patch1.61 KB

I'm adding a revised patch. The original patch doesn't fix the Drupal status report file path check.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs review » Needs work

patch doesn't apply to DRUPAL-5

nextgate’s picture

nextgate CreditAttribution: nextgate commented

Is there a patch for DRUPAL-5 ? I need this one :(

markus_petrux’s picture

markus_petrux CreditAttribution: markus_petrux commented

sorry, nevermind

ehowland’s picture

ehowland CreditAttribution: ehowland commented

After the issues with Mediafield are subtracted. I don't think this can be reliably solved without corresponding documentation about where to put the getid3 project files. I have documented one way to do this at #297258: Documentation is needed following the convention from the Audio module.

This does not correspond to the patch from jmcclelland in response #10.

No patch is needed with getid3 1.7.7 and getid3 6.x-1.x-dev and the procedure in node 297258 comment #7.

jamyers2k’s picture

jamyers2k CreditAttribution: jamyers2k commented

The problem for me is that there is no sub folder named 'lib' in 'misc' for some reason.

drew reece’s picture

drew reece CreditAttribution: drew reece commented

@ jamyers2k,

You need to create the lib folder inside misc & put getid3 library inside it. It is not a location that exists in Drupal by default.

jamyers2k’s picture

jamyers2k CreditAttribution: jamyers2k commented

Got it working. Many thanks.

IanMerwin’s picture

IanMerwin CreditAttribution: IanMerwin commented

I ran into this today... maybe this will help (my install instructions )drupal.org/node/371920#comment-1752374
The problem I had was when installing the module and the accompanying library - if one is not careful - the module will not find the library. It (by default is looking for /getid3/getid3/getid3)

Which bugged me so I tried to clean it up and get rid of at least one sub-directory by moving the files up one dir. - But, it would not find the library... it has to be "/getid3/getid3/getid3"

Hope this helps...

micahw156’s picture

micahw156
he/him/his
CreditAttribution: micahw156 commented

I just installed this in 6.x, using getid3-1.7.9 for the first time. The problem that older versions of getid3 (namely 1.7.7) had a directory structure in the zip file, but 1.7.9 ships everything flat. The extra /getid3 subdirectory was necessary with the older version of the getid3 library, but now it is not.

drewish’s picture

drewish CreditAttribution: drewish commented
Title: GetID3 lib default path is wrong » GetID3 lib default path is wrong / backport fixes from HEAD
FileSize
getid3_222666.patch8.83 KB

working on this and some other fixes.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Title: GetID3 lib default path is wrong / backport fixes from HEAD » GetID3 documentation and installation help
Category: bug » task
Priority: Normal » Critical

Very nice! Pushing to critical so it's more prominent on the issue radar.

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs work » Fixed

i actually committed this before the 5.x-1.3 release. forgot to update the status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Component: Code » Documentation
Category: task » support
Priority: Critical » Normal
Status: Closed (fixed) » Active

Some people are still confused about the installation instructions. Drush should be packed in with core so that installation would be that much easier ;-) .......

Any thoughts on how to make this easier? Thanks!

drewish’s picture

drewish CreditAttribution: drewish commented

If you're going to re-open this please be clearer on what confused people.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

actrak emailed me.......

Hey Rob;

Just have a couple of quick questions in regards to your getid3 installation instructions. Basically I don't follow what to put where. Specifically you state in instruction

1. you state "Place the entire getid3 directory into your modules directory (sites/all/modules...."
Are you talking about the .zip file?

2. pretty clear

3. pretty clear

4. do you mean sites/all/libraries/getid3/? How can you unzip the files into the /modules/ directory and have the write.php file (part of the .zip file) is in the /libraries/ directory?

5. clear

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
Issue summary: View changes
Status: Active » Needs work

Needs to be updated to work with the 7.x-2.x branch.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman commented
Parent issue: » #2330953: META: Plan for getID3 v7.x-2.0 release

Marking this as a component of the 2.0 release.