I couldn't find a way to make the beta 2 version translatable by default. So I altered the line

'#markup' => t(check_plain($range_data['label'])),

to

'#markup' => t(check_plain($range_data['label'])),

on line 87 in the date_facets_get_ranges function.

CommentFileSizeAuthor
#4 2226429-date_facets_not_translatable-4.patch416 bytesjuhaniemi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Active » Fixed

Commited to dev version.

  • Commit c8f9bf0 on 7.x-1.x by eugene.ilyin: 
    Issue #2226429 by Daemon_Byte - allow the module to be translatable

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

juhaniemi’s picture

juhaniemi CreditAttribution: juhaniemi at Wunder commented
Status: Closed (fixed) » Needs review
FileSize
2226429-date_facets_not_translatable-4.patch416 bytes

Inidividual facets were still not translatable. I had to run the label through t() aswell.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs review » Postponed (maintainer needs more info)

  • eugene.ilyin committed 6795219 on 7.x-1.x 
    Issue #2226429 by Daemon_Byte: allow the module to be translatable
eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Sorry, but I was wrong. We can't use t() for facet label, because administrator can type text on any language. We should use i18n_string module to translate facet labels.

@juhaniemi, sorry, but I don't understand what is individual facet and why it requires code from your patch.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented

So, I'm closing issue. Don't hesitate to open it again if you will have problems.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.