The funcion drupal_add_tabledrag do not exist anymore and must be replaced by a render array. This is a big change, as it remove the theme function.

Comments

  • Commit 1d92984 on 8.x-1.x by yukare: 
    Issue #2224055 by yukare: Remove drupal_add_tabledrag and use render...
yukare’s picture

yukare CreditAttribution: yukare commented
Priority: Normal » Major
Parent issue: » #2070409: [meta] Port CustomFilter to Drupal 8

The commit fixed only the fatal error, but the table still need work, it is not possible add a rule as child of another, just sort the rules, so sub-rules are not working.

dqd’s picture

dqd
(formerly "diqidoq")
CreditAttribution: dqd as a volunteer commented

@yukare: By watching the module development of the last months and the ongoing for Drupal 8, I would strongly encourage you to set the project page to "maintainer needs help" or something similar in the select boxes of the project editing page. Otherwise you will run into danger to kill the users attention for this module in the coming year. Which would be sad. I think this module is a very good and useful contribution and a very "Drupal-like" concept to extend functionality. Let us (other Drupal contrib developers) know, how we can help, and talk to people who can maybe help to push further development. There are many ways to bring life into it.

Kind regards.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at MachbarMacher commented

Seeking comaintainers? I'd volunteer. I put some work into this and brought it in a usable state:
https://www.drupal.org/sandbox/axelrutz/2957838

dqd’s picture

dqd
(formerly "diqidoq")
CreditAttribution: dqd as a volunteer and commented

Awesome! 1 mill kudos to axel.rutz!
@yukare: please talk to Axel and involve him into Drupal 8 maintainerchip to let this go on!

yukare’s picture

yukare CreditAttribution: yukare commented

Axel, i added you as manteiner, so you can start by commiting your changes. I will try to help with some issues, bit i do not promisse much, but please, commit it and open new issues, as i think we need some more updates after this.

  • axel.rutz committed 29df5be on 8.x-1.x 
    Issue #2224055 by axel.rutz: Remove drupal_add_tabledrag and use render...
geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at MachbarMacher commented
Status: Needs work » Fixed

That's great, merged the code into the dev branch.
Closing this for now, let's open followups if needed.
Feel free to PM me if something is not self-explaining!

dqd’s picture

dqd
(formerly "diqidoq")
CreditAttribution: dqd as a volunteer and commented

thumbsup!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dqd’s picture

dqd
(formerly "diqidoq")
CreditAttribution: dqd as a volunteer and commented

@axel.rutz: let's roll out a Beta to shy users not away from this awesome project. Drupal 8 needs more contrib gettting ready ;-)

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie commented

I guess you can now remove following note from module's info page:
"The version for Drupal 8 is current under development, but there is an important issue that needs to be fixed and i really need help on it #2224055: Remove drupal_add_tabledrag and use render array . Until this is fixed, the release for Drupal 8 can not be used."