Updated: Comment #1
Note that I'm not certain which version of site_audit is being used on the Pantheon dashboard: this might have already been fixed :P
Problem/Motivation
Sometimes, I want to cache a view results or rendered output for longer than 6 hours, but shorter than 6 days (say, 1 day). In this case, I choose a "Custom" caching time and enter a number of seconds (86400 seconds = 1 day).
But, Pantheon's dashboard reports lists the view in the lists of "The following Views are not caching rendered output" and "The following Views are not caching query results".
Proposed resolution
Update the Views checks so they doesn't interpret $handler->display->display_options['cache']['results_lifespan'] = 'custom';
, $handler->display->display_options['cache']['output_lifespan'] = 'custom';
to mean the view is not cached.
Remaining tasks
Review, test.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#1 | site_audit-2223783-1-views_custom_cache_lifetimes.patch | 2.09 KB | mparker17 |
Comments
Comment #1
mparker17Try this patch!
Comment #2
mparker17Comment #4
FluxSauce CreditAttribution: FluxSauce commentedThanks for the bug report and the patch! Commit is attributed to you. I ended up simplifying the logic, the max I was using initially just wasn't correct, so now it's a really straight forward if/else.