Inside of AmazonS3StreamWrapper::dir_opendir infinite loop during objects list reading. Bug caused by identical operator ===.

if (!isset($response->body->IsTruncated) || (string)$response->body->IsTruncated === 'false') {
  $truncated = FALSE;
}

but in particular this case IsTruncated is instance of the SimpleXMLEmement

P.S.:Bug detected in pair with xmlsitemap module. Every time cron were launched, site went down.

CommentFileSizeAuthor
#7 infinite_loop_dir_opendir-2222005-7.patch899 bytesjustafish
#3 infinite_loop_dir_opendir-2222005-3.patch612 bytesk.sorokin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

k.sorokin’s picture

k.sorokin CreditAttribution: k.sorokin commented
Issue summary: View changes
k.sorokin’s picture

k.sorokin CreditAttribution: k.sorokin commented
Issue summary: View changes
k.sorokin’s picture

k.sorokin CreditAttribution: k.sorokin commented
FileSize
infinite_loop_dir_opendir-2222005-3.patch612 bytes
bkonetzny’s picture

bkonetzny CreditAttribution: bkonetzny commented
Related issues: +#2204401: IMCE doesn't display due to infinite loop in dir_opendir
dhenry.redhat’s picture

dhenry.redhat CreditAttribution: dhenry.redhat commented

The attached patch appears to have resolved our never ending cron issues. It also appears to have cured a behavior where some page requests would never finish loading despite having delivered all markup for a page. This was causing timeout errors on our Selenium test suite.

dhenry.redhat’s picture

dhenry.redhat CreditAttribution: dhenry.redhat commented
Status: Active » Reviewed & tested by the community
justafish’s picture

justafish
she/her
Primary language English
Location London, UK
CreditAttribution: justafish commented
FileSize
infinite_loop_dir_opendir-2222005-7.patch899 bytes

Let's just make sure we convert it to a string and keep the identity check

  • justafish committed 6b3bc68 on 7.x-1.x 
    Issue #2222005 by justafish, k.sorokin: Fixed Infinite loop in open...
justafish’s picture

justafish
she/her
Primary language English
Location London, UK
CreditAttribution: justafish commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.