Updated: Comment #N

Problem/Motivation

Follow-up to #2217975: ConfigEntityBase::preSave() doesn't properly support renames; ConfigStorageController::save() preforms renames too early.
Our code coverage for renaming config entities is not complete.

Proposed resolution

Round out the code coverage, with PHPUnit if possible, with DUTB if that's not sensible.

Remaining tasks

Write test coverage

User interface changes

N/A

API changes

N/A

Files: 
CommentFileSizeAuthor
#2 config-2220451-2.patch35.59 KBtim.plunkett
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,402 pass(es). View

Comments

webchick’s picture

Issue tags: +Needs tests

Adding one more tag to the tag party.

tim.plunkett’s picture

Status: Active » Needs review
FileSize
35.59 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,402 pass(es). View

I wanted to get a patch out, but this still needs some work. The test coverage is a little sloppy, and it need some explanations about what we're actually testing. Setting up all the mocks for a storage controller is a lot.

tim.plunkett’s picture

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Status: Needs review » Closed (duplicate)
Issue tags: -Needs tests

Now that I found another functional bug with config entity renames, I'm going to add this test coverage while fixing that bug.

Marking as a dupe of #2226027: ConfigEntityBase::preSave() tries to load the original entity but instead loads itself