Today while I was using EVA field to attach a view to a comment, I realized that views was missing a contextual filter for comment ID.

CommentFileSizeAuthor
#1 views-add_cid_argument-2219937-1.patch781 bytesjenlampton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

Patch that adds comment ID data.

jenlampton’s picture

Patch still applies to latest version of views.

jenlampton’s picture

Patch applies to 7.x-3.15

Chris Matthews’s picture

Status: Needs review » Reviewed & tested by the community

Jen's 5 year old patch to comment.views.inc applied cleanly to the latest views 7.x-3.x-dev and works great!

DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed
Parent issue: » #2960871: Plan for Views 7.x-3.23 release

Committed. Thanks jenlampton!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ron_s’s picture

FYI, this patch needs to be rolled back asap.

Comment ID already exists as an argument/filter/field, and this patch removes the ability to sort by overriding earlier code in comment.views.inc

Please see my just posted patch: https://www.drupal.org/project/views/issues/3061720

DamienMcKenna’s picture

FYI this was reverted in #3061720: Rollback of patch #2219937 for addition of comment ID because ultimately this duplicated keys added in another issue. Doh. Sorry about the confusion.

ron_s’s picture

Thanks for taking care of it Damien, I appreciate it.