Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.field_attach_validate() is meant to be called to validate field values when saving entities programmatically:
$values = array(
'type' => 'article',
);
$node = entity_create('node', $values);
// There is no term with this tid.
$node->field_tags[LANGUAGE_NONE][0]['tid'] = 1000000;
field_attach_validate('node', $node);
The above throws an exception:
FieldValidationException: Field validation errors in field_attach_validate() (line 801 of modules/field/field.attach.inc).
This is expected and correct.
However, it also causes error messages:
Notice: Undefined offset: 1000 in taxonomy_field_validate() (line 1519 of /Users/joachim/Sites/yes-canvassing/modules/taxonomy/taxonomy.module).
Notice: Trying to get property of non-object in taxonomy_field_validate() (line 1519 of /Users/joachim/Sites/yes-canvassing/modules/taxonomy/taxonomy.module).
Comments
Comment #1
joachim CreditAttribution: joachim commentedComment #2
donquixote CreditAttribution: donquixote as a volunteer commentedI agree with the problem description. However:
- It checks
!isset($terms[$item['tid']])even if$item['tid']is empty, or 'autocreate'.Here is a patch that fixes this, and that also simplifies the code:
!==instead of!=where applicable. This also allows different start value for$validate.$tids !== array()instead of!empty($tids). Doing this allows the IDE to warn us if$tidsis an undefined variable (which it is not, but it is a good idea in general).Some things that I would wish to change, but am not addressing in this patch:
$validateto$tid_is_allowed.$validatevariable, and usecontinuestatements instead.I am not providing an interdiff, because the patches are just too different.
Comment #3
donquixote CreditAttribution: donquixote as a volunteer commentedHere is a proof-of-concept with dedicated message in case of missing term.