Node with titles 255 characters long can cause a fatal SQL error in og_default_menu_links module when the link_title is greater that 255 chars.

CommentFileSizeAuthor
#6 og_menu-max_len_on_link_title-2219071-6.patch1.15 KBcs_shadow
#1 maximum_len-2219071-1.patch1.06 KBgrasmash
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grasmash’s picture

grasmash CreditAttribution: grasmash commented
Status: Active » Needs review
FileSize
maximum_len-2219071-1.patch1.06 KB
rv0’s picture

rv0 CreditAttribution: rv0 commented
Status: Needs review » Needs work

Thanks for the patch.
Why "token_replace($default_link['label'], array('node' => $entity))" ?
Also, I think mb_substr is more appropriate

grasmash’s picture

grasmash CreditAttribution: grasmash commented

Adding token_replace allows tokens to be used in the menu titles. This is particularly useful if you'd like a default link the form of "[og-title] Home", or the like.

rv0’s picture

rv0 CreditAttribution: rv0 commented

Well, I figured that, but it seemed kinda sneaky putting it there without a mention ;)

grasmash’s picture

grasmash CreditAttribution: grasmash commented

Yes, I suppose it was. I also suppose that we should add a dependency on the token module as a result.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Status: Needs work » Needs review
FileSize
og_menu-max_len_on_link_title-2219071-6.patch1.15 KB

Modifying patch in #1 to include explanation of what token_replace is doing and added a dependency on 'token' module since token_replace is being used at a couple of places.

rv0’s picture

rv0 CreditAttribution: rv0 commented
Status: Needs review » Fixed

Committed (changed dependency to correct module .info file and added multibyte support)

  • rv0 committed d383e94 on 7.x-3.x 
    Issue #2219071 by cs_shadow, grasmash: Fixed Impose maximum length on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.