Display object may change during panel rendering [#2218487]

The objects of class panels_display are reusable, so their configuration (including context) may be changed many times during panel rendering, so I suggest to store display context data in renderer and pass renderer object to pane and region theme functions. The patch is attached.

Description of the problem.
Using panelizer and views, create a panel which contains the same panels with other contexts. In panels_display::render(), $renderer->display->context will be different in hook_panels_pre_render() and hook_panels_post_render(). The problem appears in https://drupal.org/project/panels_style_collapsible module which tries to construct region title from display context and gets the incorrect context (see #2218489: Incorrect use of display context in region render theme).

Comment	File	Size	Author
#1	panels-add_display_context-2218487-1.patch	2.36 KB	maximpodorov
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

maximpodorov CreditAttribution: maximpodorov commented 15 March 2014 at 16:30

Status:

Active

» Needs review

File	Size
panels-add_display_context-2218487-1.patch	2.36 KB

Comment #2

maximpodorov CreditAttribution: maximpodorov commented 16 March 2014 at 17:05

Issue summary:

View changes

Comment #3

maximpodorov CreditAttribution: maximpodorov commented 19 December 2014 at 09:22

Please review this patch for committing. Current Panels behavior is not correct in this sense.

Comment #4

8 January 2015 at 22:59

robmcbryde queued 1: panels-add_display_context-2218487-1.patch for re-testing.

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost commented 19 January 2015 at 08:59

+++ b/plugins/display_renderers/panels_renderer_standard.class.php
@@ -166,6 +177,7 @@ class panels_renderer_standard {
     $this->display = &$display;
+    $this->display_context = $display->context;

Maybe better implement a $display->original_context variable to store initial

Comment #6

maximpodorov CreditAttribution: maximpodorov commented 19 January 2015 at 09:21

Why?

Comment #7

maximpodorov CreditAttribution: maximpodorov commented 18 May 2015 at 08:31

Unfortunately, no one reviews this patch. Maybe I'm the only person who suffer this problem since it breaks recursive panels only. But I suggest to add this fix to the next Panels release.