Fix modal sizing [#2216873]

There are various reports of ctools modals not sizing correctly, and several attempts fix it using outerHeight() differently.

Here is another patch that attempts to fix it. More detail about the different scenarios and ways to test them are require to resolve this once and for all.

Comment 5 on #1803104: Modal dialog position after ajax load is not refreshed has a very similar patch, but that adds the parameter true where this patch adds false instead.

Comment	File	Size	Author
#10	2216873-9.patch	1.37 KB	shubham.prakash
#5	ctools-jquery-outerheight-2216873-5.patch	1.29 KB	mrjmd
#3	ctools-jquery-outerheight-2216873-3.patch	1.3 KB	mrjmd
	jquery-outerheight.patch	1.3 KB	Bevan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

2 January 2015 at 14:27

DamienMcKenna queued jquery-outerheight.patch for re-testing.

Comment #2

2 January 2015 at 16:17

Status:

Needs review

» Needs work

The last submitted patch, jquery-outerheight.patch, failed testing.

Comment #3

mrjmd CreditAttribution: mrjmd commented 10 January 2015 at 16:07

Status:

Needs work

» Needs review

File	Size
ctools-jquery-outerheight-2216873-3.patch	1.3 KB

Re-roll attached.

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 12 January 2015 at 15:05

Status:

Needs review

» Needs work

2 files were hidden/shown/deleted

File	Size
jquery-outerheight.patch	1.3 KB
ctools-jquery-outerheight-2216873-3.patch	1.3 KB

The code needs a little bit of tweaking to match the Drupal coding standards, specifically no whitespace inside of the parenthesiseses, so "(winHeight / 2)" instead of "( winHeight / 2 )".

Comment #5

mrjmd CreditAttribution: mrjmd commented 13 January 2015 at 03:41

Status:

Needs work

» Needs review

File	Size
ctools-jquery-outerheight-2216873-5.patch	1.29 KB

Fixed :)

Comment #6

maximpodorov CreditAttribution: maximpodorov commented 19 January 2015 at 11:29

I think this issue duplicates #1803104: Modal dialog position after ajax load is not refreshed.

Comment #7

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 3 January 2019 at 23:25

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

1 file was hidden/shown/deleted

File	Size
ctools-jquery-outerheight-2216873-5.patch	1.29 KB

The 4 year old patch in #5 to modal.js does not apply to the latest ctools 7.x-1.x-dev and if still applicable needs to be rerolled.

Checking patch js/modal.js...
error: while searching for:

    // Create our content div, get the dimensions, and hide it
    var modalContent = $('#modalContent').css('top','-1000px');
    var mdcTop = wt + ( winHeight / 2 ) - (  modalContent.outerHeight() / 2);
    var mdcLeft = ( winWidth / 2 ) - ( modalContent.outerWidth() / 2);
    $('#modalBackdrop').css(css).css('top', 0).css('height', docHeight + 'px').css('width', docWidth + 'px').show();
    modalContent.css({top: mdcTop + 'px', left: mdcLeft + 'px'}).hide()[animation](speed);

error: patch failed: js/modal.js:438
error: js/modal.js: patch does not apply