Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When Drupal calls the hook_entity_view() implementation in metatag.module, the language detection logic assumes that the $langcode is set correctly. This may not always be the case, and this patch changes the behaviour of the module in this case to use the detected language of the entity instead.
Comment | File | Size | Author |
---|---|---|---|
#6 | metatag-langcode-detection-2215517-6-D7.patch | 872 bytes | q11q11 |
#1 | metatag-langcode-detection-2215517-1-D7.patch | 900 bytes | achton |
Comments
Comment #1
achtonComment #2
DamienMcKennaComment #3
DamienMcKennaIf the problem is with Panels / Panelizer displays, please test the latest -dev release and #2178411: Metatags not diplaying when node content is empty.
Failing that, please explain more detail behind the structure you are using for the node pages, including any modules being used to handle the display.
Comment #4
DamienMcKennaComment #5
DamienMcKennaThis should be fixed in the latest -dev release, which will be the 1.0-rc1 release soon.
Comment #6
q11q11 CreditAttribution: q11q11 commentedIt`s not fixed in 1.0, so have to make new patch, against 1.0.
Comment #7
DamienMcKennaOk, fair enough, I'll review this when I get back from a mini vacation.
Comment #8
DamienMcKennaCould you please confirm the problem still exists in the latest dev release? Thanks.
Comment #11
jeffdiecks CreditAttribution: jeffdiecks commentedComment #12
mrjmd CreditAttribution: mrjmd commentedI believe this issue is resolved. Current dev release has the following:
I don't currently have a multilingual setup so I'm hoping someone else can test and verify.
Comment #13
DamienMcKennaComment #14
DamienMcKennaCould someone please test the latest -dev snapshot and let me know if the problem persists?
Comment #15
DamienMcKennaThere have been a bunch of changes & improvements this year, can someone please check if the problem still persists with v1.7, or the current -dev release (but be careful because i18n support is currently broken)? Thanks.
Comment #16
DamienMcKennaWe now have an extensive test suite and have not been able to reproduce this problem. If the problem persists with the latest dev release (or v1.8 due tomorrow) please reopen the issue and we'll see if we can work out what's causing the problem.