External web service requests can be expensive to run inline within a page request. This patch adds the ability to queue these operations rather than request them immediately.

CommentFileSizeAuthor
#1 share_count-add_queue-2214349-1.patch6.12 KBerikwebb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

erikwebb’s picture

erikwebb CreditAttribution: erikwebb commented
Status: Active » Needs review
FileSize
share_count-add_queue-2214349-1.patch6.12 KB
Ken Hawkins’s picture

Ken Hawkins CreditAttribution: Ken Hawkins commented
Status: Needs review » Needs work

A very needed feature.

Two comments:

1) I was very confused at first, but was able to implement the patch manually -- you seem to have rolled it in reverse.

2) I've just opened issue #2228673: Is this maintained? Perhaps better to use Social Stats -- it seems this module needs a new co-maintainer. But I stopped short of sending a request after spotting the Social Stats module that seems to do all Share Count does, and then some (like using cron).

q0rban’s picture

q0rban CreditAttribution: q0rban at Lullabot for Cisco Systems commented

The problem I foresee with this feature is that the entity may no longer exist when the queue runs, whereas without the queue, this would not be an issue. Also, the patch needs to be re-rolled as it no longer applies.

q0rban’s picture

q0rban CreditAttribution: q0rban at Lullabot for Cisco Systems commented

Another issue discovered with this patch is that on a busy website, queued items get duplicated hundreds, even thousands of times. I think it'd be best to have a dedicated database table for the queue.