On vocabulary creation, instead of "Add vocabulary" the page title displays "Edit vocabulary".

CommentFileSizeAuthor
#1 page_title_change-2214063-1.patch801 bytesbenelori
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benelori’s picture

benelori CreditAttribution: benelori commented
FileSize
page_title_change-2214063-1.patch801 bytes
benelori’s picture

benelori CreditAttribution: benelori commented
Title: Add vocabulary doesn't display correct page title. » 'Add vocabulary' page doesn't display correct page title.
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Makes sense

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch. Committed and pushed to 8.x. Thanks!

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

We generally pursue a slightly cooler method of differentiating between add and edit which is to create a separate class for each specific form. I.e.

class VocabularyAddForm extends VocabularyFormBase {
...
}

class VocabularyEditForm extends VocabularyFormBase {
...
}

(Where VocabularyFormBase contains (most of) what is in VocabularyFormController now.)

Opened #2217041: Split VocabularyFormController into VocabularyAddForm and VocabularEditForm for that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.