install_no_profile_error() is called in drupal_check_profile() and drupal_verify_profile() but does not exist!

CommentFileSizeAuthor
#5 drupal8.install-no-profile.5.patch1.15 KBswentel
#3 drupal8.install-no-profile.3.patch1.2 KBsun

Comments

xan.ps’s picture

xan.ps commented

It exists in install.core.inc file (/core/includes/).

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@xan.ps I think you'll find it was removed in #2192649: Remove drupal_set_title() from installation and update process so it's not present in 8.x HEAD

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
Issue tags: -Needs tests
StatusFileSize
new drupal8.install-no-profile.3.patch1.2 KB

Sorry! The good news:

Those code paths are dead code — the profile is validated much earlier in the process already. You are not able to get past the install_select_profile task, unless a valid profile has been selected.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
swentel’s picture

swentel commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal8.install-no-profile.5.patch1.15 KB

rerolled

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Less code++

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Removing unused code is allowed as per the beta evaluation. Committed ef53838 and pushed to 8.0.x. Thanks!

  • alexpott committed ef53838 on 8.0.x 
    Issue #2213941 by sun, swentel: install_no_profile_error() called but...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.