Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
language system
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Mar 2014 at 20:27 UTC
Updated:
29 Jul 2014 at 23:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
znerol commentedComment #2
joelpittetNice cleanup!
Comment #3
joelpittetjust noticed.
Needs a period at the end.
Worth having a second look if there is anything else.
Comment #4
znerol commentedRight, rerolled.
Comment #5
joelpittetThanks for the quick fix:) Back to RTBC.
Comment #6
webchickTriaging the queue a bit.
Comment #8
znerol commented4: 2212411-code-style-cleanup-of-language-system-3.patch queued for re-testing.
Comment #9
znerol commentedLast test-failure was a test-bot-failure. Set this to RTBC again.
Comment #11
znerol commentedTagging it for a reroll.
Comment #12
linl commentedRerolled.
Comment #14
visabhishek commented12: 2212411-code-style-cleanup-of-language-system-12.patch queued for re-testing.
Comment #15
plachJust a few remarks, otherwise looks good, thanks.
In the entity system we call the initial values param
$values. I'd do the same for consistency.lol
Am I wrong or now "returned." fits in the upper line?
Comment #16
Claudis commentedPatch from #12 applied. Tests cleanly.
Comment #17
linl commentedThanks @plach. Here's a reroll.
Comment #18
linl commentedFound another comment that was running over 80 chars and a couple of typos, so here it is again.
Comment #19
plachThanks!
Comment #20
webchickOh cool. This isn't nearly as big of a patch as I was fearing. :) I think it's cool to let this go in despite not being in a "disruptive patch period" since most of these fixes are pretty small and self-contained.
Committed and pushed to 8.x. Thanks!