Paths can be set with a SLASH on the end [#2211665]

If in the UI configuration for a field you set a directory for File Field Path that ends with a SLASH such as this one:

paper/[node:nid]/field_version_word/

Paths are generated all over with a double slash, generating random errors in different places, depending on you webserver having a double slash in a path will simply brake access to the file or end up with file permissions errors:

://paper/[node:nid]/field_version_word//xxxxxx.docx

We can blame the user for this, or simply take care of that slash in

filefield_paths_process_string($value, $data, $settings = array())

inside

\sites\all\modules\filefield_paths\modules\filefield_paths.inc

Adding the following line just at the start of the method:

$value = rtrim($value,"/");

I'll be preparing a proper patch in the following days.

And possibly, add some validation in the UI so that the path is checked for "correctness" (I don't know if this is already done, and if it is, add verification for slash at end of directory).

Comment	File	Size	Author
#2	2211665-remove-trailing-slashes.patch	465 bytes	david_garcia
#2
#1	2211665-remove-trailing-slashes.patch	465 bytes	david_garcia
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

david_garcia CreditAttribution: david_garcia commented 9 March 2014 at 17:19

Status:

Active

» Needs review

File	Size
2211665-remove-trailing-slashes.patch	465 bytes

Comment #2

david_garcia CreditAttribution: david_garcia commented 9 March 2014 at 17:52

File	Size
2211665-remove-trailing-slashes.patch	465 bytes

1 file was hidden/shown/deleted

File	Size
2211665-remove-trailing-slashes.patch	465 bytes

Rerolled against correct branch.

Comment #3

neRok CreditAttribution: neRok commented 10 March 2014 at 04:49

Title:	Paths are wrongly managed when directory set by user in UI ends with a SLASH	» Paths can be set with a SLASH on the end
Status:	Needs review	» Needs work

Thank you for identifying this issue, which I can confirm does exist. I am not sure your solution is the best though. It would probably be better to check for the slash during the form fields element_validate, as per core (see below).

However, the same check may also be required during filefield_paths_process_string, in case a token adds some slashes.

/**
 * Element validate callback for the file destination field.
 *
 * Remove slashes from the beginning and end of the destination value and ensure
 * that the file directory path is not included at the beginning of the value.
 */
function _file_generic_settings_file_directory_validate($element, &$form_state) {
  // Strip slashes from the beginning and end of $widget['file_directory'].
  $value = trim($element['#value'], '\\/');
  form_set_value($element, $value, $form_state);
}