Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
We do have the request stack.
Proposed resolution
Let's use it.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#13 | request_stack-2211617-1.patch | 3.76 KB | nesta_ |
| |||
#11 | make_use_of_the_request-2211617-11.patch | 1.07 MB | nesta_ |
#9 | make_use_of_the_request-2211617-6.patch | 4.44 KB | Miguel.kode |
#5 | make_use_of_the_request-2211617-5.patch | 4.43 KB | Nitesh Sethia |
#1 | request_stack-2211617-1.patch | 3.76 KB | dawehner |
Comments
Comment #1
dawehnerJust to get some idea out.
Comment #2
tim.plunkettI think it makes sense to use RequestStack in more services, but I'm curious about the places we have it bleeding through to forms themselves.
I think this needs to be
$this->requestStack->push($request);
I don't think any of these are right...
Comment #3
dawehnerYeah don't drink and patch.
Comment #4
jhedstromComment #5
Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer commentedRerolling the patch as per the latest D8 release.
Comment #9
Miguel.kode CreditAttribution: Miguel.kode commentedIt is a re-roll for this patch.
Comment #11
nesta_ CreditAttribution: nesta_ at La Drupalera by Emergya commentedrerolled.
Comment #13
nesta_ CreditAttribution: nesta_ at La Drupalera by Emergya commentedSorry, this Rerolled for #1
Comment #15
uzlov CreditAttribution: uzlov at Skilld commentedrequest stack (all this) already exist in 8.1.x
+ here old code (for example ViewEditFormController alredy changed to ViewEditForm)
need to close it issue
Comment #16
uzlov CreditAttribution: uzlov at Skilld commented