Updated: Comment #0

Problem/Motivation

EntityReferenceItem references other entities' IDs in the schema, but does not specify an appropriate foreign key.

Proposed resolution

Make EntityReferenceItem provide a proper foreign key.

Remaining tasks

User interface changes

-

API changes

CommentFileSizeAuthor
#39 2209067-39-entity-reference-item-foreign-key.patch789 bytesanmolgoyal74
#34 2209067-34.patch769 bytesanmolgoyal74
#32 2209067-32.patch779 bytesanmolgoyal74
#29 interdiff-26-29.txt2.56 KBjofitz
#29 2209067-29.patch788 bytesjofitz
#26 interdiff-22-26.txt1.21 KBMerryHamster
#26 2209067-26.patch2.43 KBMerryHamster
#22 2209067-22-entity-reference-item-foreign-key.patch2.13 KBanmolgoyal74
#19 interdiff-2209067-15-19.txt1.25 KBmahaveer003
#19 2209067-19-entity-reference-item-foreign-key.patch1.25 KBmahaveer003
#15 2209067-15-entity-reference-item-foreign-key.patch773 bytesAndrewsizZ
#8 2209067-8-entity-reference-item-foreign-key.patch2.02 KBAndrewsizZ
#5 2209067-5-entity-reference-item-foreign-key.patch1.51 KBtstoeckler
#5 2209067-2-5-interdiff.txt837 byteststoeckler
#2 2209067-2-entity-reference-item-foreign-key.patch1.44 KBtstoeckler
#1 2209067-1-entity-reference-item-foreign-key.patch728 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
FileSize
2209067-1-entity-reference-item-foreign-key.patch728 bytes

So I remember there was an issue where this was discussed with @yched and @amateescu where the foreign keys where dropped (which exist in the D7 version of ER), but I can't find it right now and I don't remember the exact reasoning/situation back then either. I assume there weren't any field item schemas at the time. Anyway, I think this makes sense.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
FileSize
2209067-2-entity-reference-item-foreign-key.patch1.44 KB

Actually we should probably rename those variables to the new style.

The last submitted patch, 1: 2209067-1-entity-reference-item-foreign-key.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 2: 2209067-2-entity-reference-item-foreign-key.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs work » Needs review
FileSize
2209067-2-5-interdiff.txt837 bytes
2209067-5-entity-reference-item-foreign-key.patch1.51 KB

So I totally botched up the definition of the foreign keys...

Berdir queued 5: 2209067-5-entity-reference-item-foreign-key.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: 2209067-5-entity-reference-item-foreign-key.patch, failed testing.

AndrewsizZ’s picture

AndrewsizZ CreditAttribution: AndrewsizZ commented
Status: Needs work » Needs review
FileSize
2209067-8-entity-reference-item-foreign-key.patch2.02 KB

Hey, rerolled patch and added small fix with variable name.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

AndrewsizZ’s picture

AndrewsizZ CreditAttribution: AndrewsizZ as a volunteer and at Bright Solutions GmbH for Bright Solutions GmbH commented
FileSize
2209067-15-entity-reference-item-foreign-key.patch773 bytes

Up to date patch for 8.x-5.x

AndrewsizZ’s picture

AndrewsizZ CreditAttribution: AndrewsizZ as a volunteer and at Bright Solutions GmbH for Bright Solutions GmbH commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 15: 2209067-15-entity-reference-item-foreign-key.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented

@AndrewsizZ please don't test all environments, 1 is sufficient until we know that it passes all tests. As soon as that's fixed, you can test more databases (because this does touch the database layer), but it's not needed to test on all php versions.

mahaveer003’s picture

mahaveer003 CreditAttribution: mahaveer003 as a volunteer and at Valuebound commented
Assigned: Unassigned » mahaveer003
Status: Needs work » Needs review
FileSize
2209067-19-entity-reference-item-foreign-key.patch1.25 KB
interdiff-2209067-15-19.txt1.25 KB

Added patch took reference from comment #15 and I have removed one unused variable and added interdiff file also.

Please review.

mahaveer003’s picture

mahaveer003 CreditAttribution: mahaveer003 as a volunteer and at Valuebound commented
Assigned: mahaveer003 » Unassigned

Status: Needs review » Needs work

The last submitted patch, 19: 2209067-19-entity-reference-item-foreign-key.patch, failed testing. View results

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
FileSize
2209067-22-entity-reference-item-foreign-key.patch2.13 KB

rerolled patch

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 22: 2209067-22-entity-reference-item-foreign-key.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

MerryHamster’s picture

MerryHamster CreditAttribution: MerryHamster at Skilld commented
Version: 8.5.x-dev » 8.6.x-dev
MerryHamster’s picture

MerryHamster CreditAttribution: MerryHamster at Skilld commented
FileSize
2209067-26.patch2.43 KB
interdiff-22-26.txt1.21 KB

rerolled patch and added small changes

MerryHamster’s picture

MerryHamster CreditAttribution: MerryHamster at Skilld commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 26: 2209067-26.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2209067-29.patch788 bytes
interdiff-26-29.txt2.56 KB

Remove redundant changes.

Status: Needs review » Needs work

The last submitted patch, 29: 2209067-29.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2209067-32.patch779 bytes

Re-rolled the patch for 8.7.x

Status: Needs review » Needs work

The last submitted patch, 32: 2209067-32.patch, failed testing. View results

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2209067-34.patch769 bytes

Status: Needs review » Needs work

The last submitted patch, 34: 2209067-34.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
FileSize
2209067-39-entity-reference-item-foreign-key.patch789 bytes

Added patch for 9.1.x.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Think some of the rerolls got off from #8. They just seem to jump all over the place adding some stuff back, taking it out but never saying why.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.