Query string context and relationship

It seems to work properly in my case (loading node by its nid from query string and using it to modify breadcrumbs).

I added the context and that went fine. Not knowing what to put for the "fallback" I just wrote "fallback". Then I looked to see how to make it show up somehow and realized that there was a relationship so I added the relationship to node. At that point, I realized that my "fallback" made no sense so I went back and changed it to a "2" thinking that it would fallback to NID 2 if there wasn't an NID in the query string. As soon as I saved it, I got a WSOD. Looking in the logs, there is this error:

[Mon Dec 22 17:32:28.290690 2014] [:error] [pid 23970] [client 127.0.0.1:55042] PHP 17. ctools_entity_from_query_string_context($context = *uninitialized*, $conf = *uninitialized*, *uninitialized*) /var/www/html/drupal-contrib/sites/all/modules/ctools/includes/context.inc:930, referer: http://michelle.dev/drupal-contrib/admin/structure/pages

I'm not sure what that means or how to fix it but considering I can't get to that page at all, now, due to the WSOD, something at the very least needs some error checking. :)

Let's add an access plugin while we are at it.

For the access plugin, would it not be better to check for a querystring's value versus just its mere existence?

Both is useful I guess. So a second access plugin that checks the value could be good.

I'm relatively noobish at ctools plugins. When I tried to grab the $context within the access callback, I always get null. Am I missing something?

Using the query string to trigger pane visibility and works well.

so a query string is key-value pair like

?[key]=[value]

but the form is asking us for a key on the pane configuration

I am inclined to want to put a value in here.

Lemme consider this UX some more. It's unclear.

#6 worked amazingly. Thank you so much.

Thanks,

#6 also works great for me. Using it's access plugin functionality.

#6 it works, thank you very much

Can make 2 variant and give context to access a URL parameter!

So we have some confirmations. Code looks totally straightforward.

Worked well for me!

+++ b/plugins/contexts/query_string.inc
@@ -0,0 +1,89 @@
+      $context->data = $_GET[$data['key']];

Need a check_plain here?

> Need a check_plain here?

Sanitization is done on output, so imho no.
https://www.drupal.org/node/28984

Setting this back to RTBC then.

LGTM

The patch (of course, given it's just new files applies cleanly to current 7.x-1.x.

I did a simple visual check of the code and think some example use-cases would be helpful in the @file comment block and/or in the plugin description string, as I had to look hard to 'get' what was meant. I was tripped up by what 'query string' meant.. my head was full of SQL. I guess I'm in agreement with #11

However, that doesn't change whether the code works, and at least there are comments :-)

I think overall looks good to go... can always improve later.

Okay otherwise this works fine, and doesn't change anything else so thats good. Committed!

The contributors to this issue may be interested in a feature request with patch that I just posted:

#3032363: Allow setting NULL as fallback value in query string context