Hey!

I didn't have much time to investigate, but it seems that for some reason save button doesn't work on my foundation based theme. I tracked the problem down to homebox.js file, line 16 where the button mousedown element is defined.

I changed the line from
Drupal.homebox.$pageSave = $homebox.find('#homebox-save-form input[type=submit]');
to
Drupal.homebox.$pageSave = $homebox.find('#homebox-save-form button[type=submit]');
because that button wasn't firing at all.

I'm not sure if that input element was replaced by some override in foundation theme or what, but I solved this issue by patching my homebox.js in my profile file, and all is working atm.

Cheers,

Janne

CommentFileSizeAuthor
#5 homebox_save-button-not-fired-on-some-theme-2201955-5.patch586 bytesAndrewsizZ
#3 issue-2201955-homebox-saves-in-bootstrap.patch598 bytesD34dMan
#1 homeboxjs-btnvsinput.patch532 bytesjiisuominen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jiisuominen’s picture

jiisuominen CreditAttribution: jiisuominen commented
FileSize
homeboxjs-btnvsinput.patch532 bytes
WillowDigit’s picture

WillowDigit CreditAttribution: WillowDigit commented

I can confirm that I had the same issue on Bootstrap 3.x theme, and that patch #1 fixed it for me.

D34dMan’s picture

D34dMan CreditAttribution: D34dMan commented
Status: Active » Needs review
FileSize
issue-2201955-homebox-saves-in-bootstrap.patch598 bytes

Patching as with #1 works. but would break in other themes where it is working normally. So i modified the patch to make it better.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Needs work

I think '#homebox-save-form [type=submit]' will work as a selector for both. If the button has a consistent ID, that would be even better.

A code comment explaining the selector should be added.

AndrewsizZ’s picture

AndrewsizZ CreditAttribution: AndrewsizZ commented
Status: Needs work » Needs review
FileSize
homebox_save-button-not-fired-on-some-theme-2201955-5.patch586 bytes

Attached new patch

  • drumm committed 53ae05c on 7.x-2.x authored by AndrewsizZ 
    Issue #2201955 by 5to1, D34dMan, AndrewsizZ: Homebox save button not...
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Needs review » Fixed

Looks good, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.