First of all thank you for this module, the idea behind it is really useful
I'm facing a case in which i have multiple conditions but i only need to satisfy one of them in the rule
Is there any way to achieve this at this moment , if not ill look into making a patch for it

CommentFileSizeAuthor
#6 inline_conditions-add_logic_operators-2200225-6.patch10.95 KBjkuma
#5 inline_conditions-add_logic_operators-2200225-5.patch10.45 KBjkuma
#3 inline_conditions-add_logic_operators-2200225-3.patch8.51 KBjkuma
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jkuma’s picture

jkuma CreditAttribution: jkuma commented
Status: Active » Needs work

Hello,

Thanks for the message, glad to hear that you find the module useful. It's really a feature requested by many and We plan to add it very soon. If you have time to do it, please feel free to post a patch. Unfortunately, the only condition exposed by IC is "AND" so far, but like I said, it's really something we want to add.

jkuma’s picture

jkuma CreditAttribution: jkuma commented
Assigned: Unassigned » jkuma

I have almost finished to implement this feature. I'm taking the lead. Please accept all my apologies if you was already working on it.

jkuma’s picture

jkuma CreditAttribution: jkuma commented
Status: Needs work » Needs review
FileSize
inline_conditions-add_logic_operators-2200225-3.patch8.51 KB

Please, find the patch attached attempting to implement this feature request.

jkuma’s picture

jkuma CreditAttribution: jkuma commented
Title: Allow the option for "ORing" conditions » Add logical operators at inline condition
jkuma’s picture

jkuma CreditAttribution: jkuma commented
FileSize
inline_conditions-add_logic_operators-2200225-5.patch10.45 KB

Please ignore my last patch, this one handles correctly the interface with rules.

jkuma’s picture

jkuma CreditAttribution: jkuma commented
FileSize
inline_conditions-add_logic_operators-2200225-6.patch10.95 KB

Final patch with fixes around rules integration.

jkuma’s picture

jkuma CreditAttribution: jkuma commented
Status: Needs review » Fixed

I've test the last patch all way around and it appears to work fine. Please, feel free to re-open this post if you are encountering any issues.

Pushed in the 7.x-1.x branch. diff

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

josebc’s picture

josebc CreditAttribution: josebc commented

Thank you a lot for the patch and sorry for the late reply
Ill do some additional testing and report back
i believe this is a huge improvement to the module

josebc’s picture

josebc CreditAttribution: josebc commented

Patch works as described