Hi,
Is there plans to introduce D8 version of this module?
We (@InternetDevels team) would like to help you with development of this version.
Thanks, aragorn.

CommentFileSizeAuthor
#12 menu_firstchild-better_input_description-2200147-12-D8.patch797 bytesdieppon
#10 Drupal-8-version-UX_2200147.patch859 bytesCauliflower
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anrikun’s picture

anrikun CreditAttribution: anrikun commented

Yes, you can contribute code if you want.

dmytro-aragorn’s picture

dmytro-aragorn
Primary language Ukrainian
Location Lutsk
CreditAttribution: dmytro-aragorn commented
Assigned: Unassigned » dmytro-aragorn

Thanks! I'll try to do my best

fholzer’s picture

fholzer CreditAttribution: fholzer commented

any updates on this ?
No one working on it ?

platinum1’s picture

platinum1 CreditAttribution: platinum1 commented

Is anyone working on this project?

ankitsingh0188’s picture

ankitsingh0188
he/him
Primary language English
CreditAttribution: ankitsingh0188 commented

What is the progress?

johnnny83’s picture

johnnny83 CreditAttribution: johnnny83 commented

Same question :D

Bart Vanhoutte’s picture

Bart Vanhoutte CreditAttribution: Bart Vanhoutte at Duo commented

I have created a Drupal 8 port of menu_firstchild. You can find it on GitHub at https://github.com/bartvanhoutte/menu_firstchild.

Can we get this up on drupal.org? I would like to become maintainer of the Drupal 8 version of this module.

baekelandt’s picture

baekelandt CreditAttribution: baekelandt at Duo commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Active » Needs review

Bart uploaded the first version of this d8 port on d.o., feel free to try it.

The only issue that we found so far is #2846634: D8 port doesn't fully work with menu_block

dpacassi’s picture

dpacassi
Primary language English
Location Zürich, Switzerland
CreditAttribution: dpacassi at Liip for PHSG commented
Status: Needs review » Reviewed & tested by the community

I'm using the current dev version on a D8.2.6 site without any problems/bugs.
I'm not even affected by the bug appearing when limiting the maximum amount of levels (#2846634).

Cauliflower’s picture

Cauliflower CreditAttribution: Cauliflower commented
FileSize
Drupal-8-version-UX_2200147.patch859 bytes

Some small UX improvements:
- Description completed to checkbox field,
- Position of field above link field.

anrikun’s picture

anrikun CreditAttribution: anrikun commented
Status: Reviewed & tested by the community » Needs review

I guess patch at #10 needs some review.

dieppon’s picture

dieppon CreditAttribution: dieppon as a volunteer commented
FileSize
menu_firstchild-better_input_description-2200147-12-D8.patch797 bytes

#10 Does not improve UX, the position of the checkbox is correct, I have summited a new patch with just the new input text.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented

@dieppon, your patch in #12 applied cleanly to 8.x-dev and works great for me after testing with Drupal core 8.7.3. I would change to RTBC, but it would be best if at least one other person could review. I would love to see at least an 8.x-alpha release soon.

tekNorah’s picture

tekNorah
she/her/hers
Location Mokena, IL, US
CreditAttribution: tekNorah at tekNorah commented
Status: Needs review » Reviewed & tested by the community

Code looks good, patch from #12 looks good, tested as working with Drupal core 8.7.5.

Moving to RTBC. Lets get this merged and released!

  • pingevt committed c2ca918 on 8.x-1.x 
    Issue #2200147 by dieppon, Cauliflower: Drupal 8 version
pingevt’s picture

pingevt CreditAttribution: pingevt at Bluecadet commented
Status: Reviewed & tested by the community » Fixed

Added the patch from #12. Fixed for now and will be creating releases soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.