Metatag

Couldn't find an issue for this.

Small feature request.

When using the Metatag (https://drupal.org/project/metatag) module to provide page titles, still get a warning:

Page titles Disabled
You have not enabled the Page titles module. This module can help out with problems such as pages with paging being marked as duplicate content by search engines.

This could read:

Page titles Disabled
You have not enabled the Page titles (or equivalent module). This module can help out with problems such as pages with paging being marked as duplicate content by search engines.

with the proper logic added. The warning would then not show when another module is providing page titles.

That's all, Cheers.

Comment	File	Size	Author
#4	prod_check-n2198907-4.patch	360 bytes	DamienMcKenna
#4
#1	prod_check-n2198907-1.patch	2.23 KB	DamienMcKenna
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 27 June 2015 at 14:59

Status:

Active

» Needs review

File	Size
prod_check-n2198907-1.patch	2.23 KB

Given that Page Title is made redundant by Metatag, just remove the Page Title integration.

Comment #2

malc0mn CreditAttribution: malc0mn commented 28 July 2015 at 08:38

Version:	7.x-1.x-dev	» 6.x-1.x-dev
Assigned:	Unassigned	» malc0mn
Status:	Needs review	» Patch (to be ported)

Good point, but I would not remove page titles. Some projects will be happy with just that module active, others need more. So I 'adjusted' the patch to this:

diff --git a/prod_check.module b/prod_check.module
index 428f88a..2fb5bb4 100755
--- a/prod_check.module
+++ b/prod_check.module
@@ -1757,6 +1757,10 @@ function _prod_check_metatag($caller = 'internal') {
 }
 
 function _prod_check_page_title($caller = 'internal') {
+  if (module_exists('metatag')) {
+    return;
+  }
+
   $check = array();
   $error = FALSE;
   $pager = variable_get('page_title_pager_pattern', '');
@@ -1773,7 +1777,7 @@ function _prod_check_page_title($caller = 'internal') {
   if (!module_exists('page_title')) {
     $error = TRUE;
     $value_nok = t('Disabled');
-    $msg_nok = t('You have not enabled the !link module. This module can help out with problems such as pages with paging being marked as duplicate content by search engi
+    $msg_nok = t('You have not enabled the !link (or equivalent) module. This module can help out with problems such as pages with paging being marked as duplicate conten
   }
   else if (empty($pager)) {
     $error = TRUE;

Comitted to the 7.x-1.x-dev branch.

Thanks!

mlc.