Obsolete schema file or is that a bug?
[18:21] sun: there is actually no used display extender in views itself, just contrib modules define some, so you probably don't need one schema file
No idea if this even needs a patch but here you go.
As I'm not familiar with this code, I don't know what the appropriate action here is, but to add some more insights from IRC:
18:23 sun dawehner: but if it's a known/declared thing in Views, then I guess the config schema should declare how the (base) display extender configuration is supposed to look in terms of data types, no?
18:31 aspilicious_home dawehner: sun has a point
18:35 dawehner sun: i guess we want something like at the beginning of views.style.schema.yml
So we likely still want to delete that file, but additionally add some base plugin data type schema for display extenders in views.display.schema.yml?
Let's get someone in with more knowledge of schema files.
Currently we don't have any display extender specific configuration in core (DefaultDisplayExtender has no addition options). If we need to introduce new data type, it can be something like below:
diff --git a/core/modules/views/config/schema/views.data_types.schema.yml b/core/modules/views/config/schema/views.data_types.schema.yml
index 4f3a87e..1a8f4dc 100644
@@ -242,6 +242,9 @@ views_display:
label: 'Hide attachments in summary'
+ type: mapping
label: 'Sort criteria'
But not sure how it would add value to plugins from contrib module
The dedicated views_display_extender type would make sense if in the future core adds more properties to it by default. If not, then it is just an alternate name for mapping. AND since we don't allow schemas to change, it should not change in the future either, right? :) So don't see the use for a dedicated type until we have base data on it.
As long as Views maintainers are fine with having no schema for display extenders (and that was @dawehner's initial response), this is good to go :-)
Fixing that typo in the issue title. ;)
Committed 1ca2032 and pushed to 8.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
Drupal is a registered trademark of Dries Buytaert.