Remove empty views.display_extender.schema.yml file [#2197877]

Comment	File	Size	Author
#4	2197877-remove-empty-views-config-4.patch	197 bytes	kirby14

Comment #1

sun

German

Karlsruhe

CreditAttribution: sun commented 16 February 2014 at 17:14

Parent issue:

» #2167623: Add test for all default configuration to ensure schema exists and is correct

Log in or register to post comments

Comment #2

dawehner

German

CreditAttribution: dawehner commented 16 February 2014 at 17:22

Issue tags:

+Novice

[18:21] sun: there is actually no used display extender in views itself, just contrib modules define some, so you probably don't need one schema file

Log in or register to post comments

Comment #3

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2014 at 17:32

Title:

views.display_extender.schema.yml is empty (0 bytes)

» Remove emtpy views.display_extender.schema.yml file

Log in or register to post comments

Comment #4

kirby14 CreditAttribution: kirby14 commented 16 February 2014 at 17:54

Status:

Active

» Needs review

File	Size
2197877-remove-empty-views-config-4.patch	197 bytes

No idea if this even needs a patch but here you go.

Log in or register to post comments

Comment #5

sun

German

Karlsruhe

CreditAttribution: sun commented 16 February 2014 at 18:24

As I'm not familiar with this code, I don't know what the appropriate action here is, but to add some more insights from IRC:

18:23 sun dawehner: but if it's a known/declared thing in Views, then I guess the config schema should declare how the (base) display extender configuration is supposed to look in terms of data types, no?

18:31 aspilicious_home dawehner: sun has a point

18:35 dawehner sun: i guess we want something like at the beginning of views.style.schema.yml

So we likely still want to delete that file, but additionally add some base plugin data type schema for display extenders in views.display.schema.yml?

Log in or register to post comments

Comment #6

dawehner

German

CreditAttribution: dawehner commented 16 February 2014 at 20:24

Assigned:

Unassigned

» vijaycs85

Let's get someone in with more knowledge of schema files.

Log in or register to post comments

Comment #7

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 February 2014 at 20:53

Currently we don't have any display extender specific configuration in core (DefaultDisplayExtender has no addition options). If we need to introduce new data type, it can be something like below:

diff --git a/core/modules/views/config/schema/views.data_types.schema.yml b/core/modules/views/config/schema/views.data_types.schema.yml
index 4f3a87e..1a8f4dc 100644
--- a/core/modules/views/config/schema/views.data_types.schema.yml
+++ b/core/modules/views/config/schema/views.data_types.schema.yml
@@ -242,6 +242,9 @@ views_display:
       type: boolean
       label: 'Hide attachments in summary'

+views_display_extender:
+  type: mapping
+
 views_sort:
   type: views_handler
   label: 'Sort criteria'

But not sure how it would add value to plugins from contrib module

Log in or register to post comments

Comment #8

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 17 February 2014 at 16:10

The dedicated views_display_extender type would make sense if in the future core adds more properties to it by default. If not, then it is just an alternate name for mapping. AND since we don't allow schemas to change, it should not change in the future either, right? :) So don't see the use for a dedicated type until we have base data on it.