Comments

p0wer’s picture

Priority: Normal » Major
FileSize
523.28 KB

This is crucial for a specific situation: a webpage displayed inside an iframe with Internet Explorer 11 causes "SCRIPT5: permission denied" or "SCRIPT70: permission denied", as described here: http://bugs.jquery.com/ticket/14535 . While some Google answers say this has been known since 1.10.1 and fixed in 1.10.2, this error still applies to 1.10.2 and is resolved in 1.11.0 .

p0wer’s picture

Status: Active » Needs review
espurnes’s picture

It seems the patch is not relative to the jquery_update folder. It's relative to the root folder.

I tried to patch it and I get the next messages

$> patch -p1 < patch-jQuery-Update-1.11.patch 
patching file sites/all/modules/jquery_update/jquery_update.module
Hunk #2 succeeded at 182 (offset 9 lines).
Hunk #3 succeeded at 198 (offset 10 lines).
Hunk #4 FAILED at 241.
Hunk #5 succeeded at 283 (offset 15 lines).
1 out of 5 hunks FAILED -- saving rejects to file sites/all/modules/jquery_update/jquery_update.module.rej
patching file sites/all/modules/jquery_update/replace/jquery/1.11/jquery-1.11.0.min.map
patching file sites/all/modules/jquery_update/replace/jquery/1.11/jquery.js
patching file sites/all/modules/jquery_update/replace/jquery/1.11/jquery.min.js

I don't know if this has a bad effect. But now I can choose jQuery 1.11.

Thanks klonos

markcarver’s picture

Title: Offer latest jQuery 1.11.x as an option (currently 1.11.0). » Offer latest jQuery 1.11.x as an option
Component: jQuery 1.10.x » jQuery 1.11.x
Category: Task » Feature request
Priority: Major » Normal
Status: Needs review » Needs work

This needs to be relative to the project folder, not a site install.

jantoine’s picture

Status: Needs work » Needs review
FileSize
522.24 KB

Updated patch attached. I noticed an issue with the jQuery CDN, but other than that, patch is working good.

Anonymous’s picture

..

I try to apply the patch:

Cheking patch jquery_update.module...
error: while searching for:
// If the ajax version is set then that one always win.
if (!empty($_POST['ajax_page_state']['jquery_version'])) {
$ajax_version = $_POST['ajax_page_state']['jquery_version'];
if (in_array($ajax_version, array('default', '1.5', '1.6', '1.7', '1.8', '1.9', '1.10'))) {
$version = $ajax_version;
}
}
error: patch failed: jquery_update.module:97
error: jquery_update.module: patch does not apply
Checking patch replace/jquery/1.11/jquery-1.11.0.min.map...
Checking patch replace/jquery/1.11/jquery.js...
Checking patch replace/jquery/1.11/jquery.min...

What's the problem?

jantoine’s picture

@dadaaahm,

Ensure you are following the patching instructions here: https://www.drupal.org/patch/apply. Also, ensure you are applying to the latest 2.x-dev release. If still encounter these errors, the patch may no longer apply and would need to be updated.

jantoine’s picture

@dadaaahm,

I just tested and the patch in #5 still applies.

Anonymous’s picture

Thank you very much. I just used the version 7.x-2.4 instead of 7.x-2.x-dev, that's all.

kamranzafar’s picture

I have applied the patch manually as line numbers were not matching. It is working fine for but I hope we will get the proper release of jQuery Update module soon. If anyone needs I can provide the patched version.

--
Kamran Zafar
http://www.cognitiveaxis.com/

xpersonas’s picture

The patch from #5 worked for me on 7.x-2.x-dev as well. Hopefully this doesn't cause any weird compatibility issues that I won't find until much later in the project. Very interested in a proper release as well.

artemln’s picture

Updated jQuery version to 1.11.1

artemln’s picture

And patch with jQuery files.

artemln’s picture

artemln’s picture

SiliconMind’s picture

Status: Needs review » Reviewed & tested by the community

#14 works fine on branch 7.x-2.x.

SiliconMind’s picture

Status: Reviewed & tested by the community » Needs work

Sorry for the mess. I just noticed that this one doesn't have jQuery UI 1.11 but still uses 1.10.2. Can we add the latest jQuery UI too?

SiliconMind’s picture

Patch including jQuery UI 1.11.2.
Two files: with JS/CSS files and without them.

Jose Reyero’s picture

Taking a look and testing some patches here with latest Drupal core:

#14 seems to work fine.

#18 (both versions) not really working, when visiting block or taxonomy admin pages js seems to be disabled, no drag & drop
Also the second patch seems to have too many lines with other changes to files like AUTHORS.txt

I've tested with Drupal 7.33 and Chromium 37 (Ubuntu 14.04)

SiliconMind’s picture

Jose, just take a look at AUTHORS.txt changes - some people changed e-mail addresses plus there are more contributors. What do you expect me to do about that? :)

Did you test the right patch? The smaller one does not include jQuery files, so that could be the reason why it didn't work for you. Try the large one - just tested again and blocks admin page drag'n'drop works fine on Safari. Make sure you use add_1.11_jquery_and_jqueryui_WITHJS-2197249-18.patch file. Did get any console errors?

smerth’s picture

Hi SilconMind,

I applied the patch > add_1.11_jquery_and_jqueryui_WITHJS-2197249-18.patch to the latest dev version of jQuery update and the update to 1.11 is working. So far the functions I have tested have worked.

But it seems that the admin overlay functionality is not working after the update...

SiliconMind’s picture

Hi smerth,

I just tested the overlay and it works fine for node and user edit pages. I'm not using overlay at all, but I tested with standard seven theme for administrative pages and everything seems fine. Even Views pages works in overlay on my end. What theme did you try and what admin pages?

claudiu.cristea’s picture

@SiliconMind, #18 WITH JS is missing the jQuery 1.11 library. It adds only the latest UI.

Here's a patch containing the module plus the libraries.

drclayt0n’s picture

i could not get #23 to apply correctly for me (i use netbeans to patch tho)

#14 seemed to work for me so far.

arosboro’s picture

#23 worked for me with the command patch -p1 < offer_latest_jquery-2197249-23.patch from inside sites/all/modules/contrib/jquery_update

The only thing I noticed is that the CDN code does not apply cleanly to the version I am using:

version = "7.x-2.4"
core = "7.x"
project = "jquery_update"
datestamp = "1396482246"

Lines 395:62 and 401:56 need to be set, for some reason it was 1.11.2 instead of 1.11.1 with the cdns in jquery_update_jqueryui_replace().

arosboro’s picture

Status: Needs review » Needs work

Also,

//# sourceMappingURL=jquery.min.map

should be moved to line 2 and changed to //@ to resolve the min.map 404 error that occurs from trying to load /jquery.min.map.

/*! jQuery v1.11.1 | (c) 2005, 2014 jQuery Foundation, Inc. | jquery.org/license
//@ sourceMappingURL=jquery.min.map
 */
markcarver’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
GerZah’s picture

Confirm: Patch #23 offer_latest_jquery-2197249-23.patch works nicely on jquery_update-7.x-2.5.tar.gz.

RobLoach’s picture

Title: Offer latest jQuery and UI (1.11) as option » Offer latest jQuery UI 1.11.4

Updated to be for latest jQuery UI. Latest jQuery is in there.

djroshi’s picture

FileSize
2.6 MB

Latest jQuery UI 1.11.4. Patch is against 7.x-3.x-dev. Hopefully this looks OK, they have restructured the jQuery UI lib quite drastically so there are no longer individual files for each widget/effect/etc.

rudraram’s picture

@djroshi The above patch fails while applying.

vbard’s picture

patch #30 fails on latest dev

rivimey’s picture

It looks like patch #30 fails because the image files (png etc) are not included in the patch.notice that the previous patch #23 is significantly larger.

tamarpe’s picture

#14 works well here

amme’s picture

chrisgross’s picture

The latest dev already includes the latest jQuery library, but does not update UI to 1.12.1 and it looks like 1.11 didn't have the accessibility kinks worked out. Since the parent issue is still being worked on, here is a CDN-only patch (basically an updated version of the nojs patch in #18) that includes that version, which can be used in the meantime.

chrisgross’s picture

Turns out 1.12.1 breaks, at the very least, Views AJAX pagers. Here is a CDN-only patch with 1.11.4.