Problem/Motivation

The tour of the views config page has some grammar issues and also needs to be updated to align with emerging tour standards.

Proposed resolution

Update the tour to clean up tips.

CommentFileSizeAuthor
#5 8581517-5-views-ui-tour-update.patch6.04 KBtstoeckler
#3 Screenshot from 2014-03-17 09:21:29.png13.57 KBkattekrab
#1 views-ui-tour-update-2195967-1.patch5.96 KBpameeela
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pameeela’s picture

pameeela CreditAttribution: pameeela commented
FileSize
views-ui-tour-update-2195967-1.patch5.96 KB

Patch attached with content changes. Also updated the order of tips to match weights.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Status: Active » Needs review
kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented
FileSize
Screenshot from 2014-03-17 09:21:29.png13.57 KB

Looked over all the strings in the patch, and have a couple of suggestions. Also fired it up in simplytest.me, and it looks good to me! Definitely an improvement. Will leave as needs review for now, these suggestions are minor, and shouldn't block progress.

  1. +++ b/core/modules/views_ui/config/tour.tour.views-ui.yml
@@ -75,16 +74,15 @@ tips:
+    body: 'Add, rearrange or remove sorting rules.'

    suggestion...

    Add, rearrange or remove rules for sorting this content. 

  2. +++ b/core/modules/views_ui/config/tour.tour.views-ui.yml
@@ -75,16 +74,15 @@ tips:
+    body: 'Show a preview of the view output.'

    Instead of

    "Show a preview of the view output."

    How about...

    "Review and test the outcome of any changes made before saving this view by clicking 'Update preview'"

kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented
Title: Update content of views tour to align with stanards » Update content of views tour to align with standards
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community
FileSize
8581517-5-views-ui-tour-update.patch6.04 KB

@pameeela: Finally got to take a look at this. I hadn't forgotten, but last week was kind of crazy. Sorry for taking so long!

Needed a re-roll after #2233787: Move default configuration into extension/config/install to clarify its purpose.

Checked the resulting texts by trying out the tour before and after locally and the texts are much more concise and helpful afterwards. Awesome!

Since it was just a re-roll hope it's OK that I'm going straight to RTBC.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

Oh, just re-saw #3: I think the conciseness added by this patch is quite nice, so I would in fact disagree with the first point. I like the second suggestion as that seems to be useful hint. I'll leave it to the committers though to push this back if they think this shouldn't go in as is.

kattekrab’s picture

kattekrab CreditAttribution: kattekrab commented

My suggestions are safe to ignore here :)

Let's get this done!

RTBC for sure.

- D.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 57106fe and pushed to 8.x. Thanks!

  • Commit 57106fe on 8.x by alexpott: 
    Issue #2195967 by tstoeckler, pameeela: Update content of views tour to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.