The function _assets_get_icons() in asset.module uses scandir() to get all elements from ASSET_MODULE_PATH . '/ckeditor/buttons/' and then just checks for '.' and '..'. Having this in SVN control causes a weired "Read Error! ..." NOTICE, caused by using getimagesize() on the '.svn' directory.

Fix is simpel, exchange the
if (!in_array($file_name, array('.', '..'))) {
for
if (!is_dir($file_name)) {

Patch attached.

CommentFileSizeAuthor
#3 svn-folder-read-error-2193675-2.patch582 bytesIRuslan
#1 icon_scan_directory_check-2193675-1.patch424 bytesChristianAdamski
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented
FileSize
icon_scan_directory_check-2193675-1.patch424 bytes
IRuslan’s picture

IRuslan CreditAttribution: IRuslan commented
Status: Needs review » Closed (fixed)

Sorry, but your patch not working, because is_dir() should have directory path, but not only folder name.
We solved this problem in another way. Thank you for your help.
Committed to dev branch.

IRuslan’s picture

IRuslan CreditAttribution: IRuslan commented
FileSize
svn-folder-read-error-2193675-2.patch582 bytes