Function docs incorrect in ConfigManager after #2188595-26: Create a ConfigManager to be able to remove config.inc

Please credit andypost in the commit and not me since he wrote the patch. I'm just moving it to a new issue.

Files: 
CommentFileSizeAuthor
#6 2188595-follow-up_6.patch3.35 KBandypost
PASSED: [[SimpleTest]]: [MySQL] 64,592 pass(es). View
#6 interdiff.txt750 bytesandypost
#5 2188595-follow-up_5.patch3.17 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View

Comments

jhodgdon’s picture

Did you mean to have a code patch as well as a docs patch here? Want to go ahead and commit it then -- I don't normally do code patches? The docs look OK to me.

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
andypost’s picture

Issue summary: View changes

Alex, suppose you can commit this one because this patch was originally filed by me

jhodgdon’s picture

Component: documentation » configuration system
andypost’s picture

FileSize
1.81 KB
3.17 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion. View
andypost’s picture

FileSize
750 bytes
3.35 KB
PASSED: [[SimpleTest]]: [MySQL] 64,592 pass(es). View

The last submitted patch, 5: 2188595-follow-up_5.patch, failed testing.

alexpott’s picture

+++ b/core/lib/Drupal/Core/Config/ConfigManager.php
@@ -80,8 +86,8 @@ public function getEntityManager() {
-    //   https://drupal.org/node/2188595
-    require_once DRUPAL_ROOT . '/core/lib/Drupal/Component/Diff/DiffEngine.php';
+    //   https://drupal.org/node/1848266
+    require_once __DIR__ . '/../../Component/Diff/DiffEngine.php';

Why the change to __DIR__ ? Like this code can't be unit tested anyway and using DRUPAL_ROOT makes things less likely to break.

alexpott’s picture

YesCT’s picture

6: 2188595-follow-up_6.patch queued for re-testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 19f5b35 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.