Function docs incorrect in ConfigManager after #2188595-26: Create a ConfigManager to be able to remove config.inc

Please credit andypost in the commit and not me since he wrote the patch. I'm just moving it to a new issue.

CommentFileSizeAuthor
#6 2188595-follow-up_6.patch3.35 KBandypost
#6 interdiff.txt750 bytesandypost
#5 2188595-follow-up_5.patch3.17 KBandypost
#5 interdiff.txt1.81 KBandypost
2188595-follow-up_1.patch1.59 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Did you mean to have a code patch as well as a docs patch here? Want to go ahead and commit it then -- I don't normally do code patches? The docs look OK to me.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: jhodgdon » Unassigned
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes

Alex, suppose you can commit this one because this patch was originally filed by me

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Component: documentation » configuration system
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt1.81 KB
2188595-follow-up_5.patch3.17 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt750 bytes
2188595-follow-up_6.patch3.35 KB

The last submitted patch, 5: 2188595-follow-up_5.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented 
+++ b/core/lib/Drupal/Core/Config/ConfigManager.php
@@ -80,8 +86,8 @@ public function getEntityManager() {
-    //   https://drupal.org/node/2188595
-    require_once DRUPAL_ROOT . '/core/lib/Drupal/Component/Diff/DiffEngine.php';
+    //   https://drupal.org/node/1848266
+    require_once __DIR__ . '/../../Component/Diff/DiffEngine.php';

Why the change to __DIR__ ? Like this code can't be unit tested anyway and using DRUPAL_ROOT makes things less likely to break.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Ok #1827448: Use __DIR__ instead of DRUPAL_ROOT where possible/sensible here is why we're using __DIR__

YesCT’s picture

YesCT CreditAttribution: YesCT commented

6: 2188595-follow-up_6.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 19f5b35 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.