Hi. Im having a problem using your module with the Pleroma theme. Everything looks great on long posts but short posts have stuff that pops out of the boxes. I would just like to say keep up the good work i love the look with this. I currently use flatforum on my live site and im running your mod on my test server until it is out of alpha. I cant wait to implement this on my live site.

CommentFileSizeAuthor
overlap.JPG99.07 KBlainwired
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lainwired’s picture

Category: bug » support
Delta Bridges’s picture

Same problem here... great module btw :):)

Democron’s picture

I'm also having this problem but I have one more layout bug in Firefox only, look at screenshots:

http://uploads.screenshot-program.com/my.php?image=upl6921427998.png
http://uploads.screenshot-program.com/my.php?image=upl2648146615.png

lainwired’s picture

Sorry here is the link for the picture

http://drupal.org/files/issues/overlap.JPG

it looks exactly the same in IE7

Michelle’s picture

Title: Some things are leaking out of my boxes » Short posts cause
Category: support » bug

This is a bug in the CSS because it can't deal with short posts. But I have no clue how to fix it. Everything I try makes it worse. I only know enough CSS to get by so unless someone with a clue steps up, this is going to be broken, I'm afraid.

Michelle

Democron’s picture

Title: Short posts cause » Some things are leaking out of my boxes
Category: bug » support

Here is my fix:

In forum-thread.tpl.php you will find this piece of code in the bottom of the file:

    <div class="links">
    <?php print $links ?>
  </div>
  
  </div>
  <span class="clear"></span>
  
  
  
</div>

Replace the line <span class="clear"></span> with <div class="clear"></div>

Now open file advanced_forum.css and add this code in the bottom:

.clear {
	clear: both;
}
Democron’s picture

*UPDATE*

Here is my fix:

In forum-thread.tpl.php find every line <span class="clear"></span> and replace it with <div class="clear"></div>

Now open file advanced_forum.css and add this code in the bottom:

.clear {
	clear: both;
}
Michelle’s picture

Title: Some things are leaking out of my boxes » Short posts cause user info to leak out the bottom of the box
Category: support » bug
Status: Active » Fixed

Ok, I changed the spans to divs. The CSS was already there. Seems to work so I committed it. Thanks!

Michelle

Democron’s picture

Also if somebody else has the same bug I did (http://uploads.screenshot-program.com/my.php?image=upl2648146615.png) here is solution for that.

In file forum-display.tpl.php find the line
40: $output .= '<span class="clear"></span>';

Cut it and paste it after this piece of code:

<?php
      else if ($user->uid) {
        $output .= t('You are not allowed to post a new forum topic');
      }
      else {
        $output .= '<div id="newtopiclink" class="cssbutton">';
        $output .= t('<a href="@login">Login to post a new forum topic</a>', array('@login' => url('user/login', drupal_get_destination()))) ;
        $output .= '</div>';
      }
      $output .= '<span class="clear"></span>';  // <= paste it here
?>

Ignore the <?php and ?> in the code above, I just added it so the code gets coloured

lainwired’s picture

Thanks a lot guys. I love how active you all are on this project.

Michelle’s picture

Thanks, democron. I had it partially fixed in the commit I did this morning but didn't realize that the "post" button fell into the header when there was no pager. The fix was a bit more complex than what you have there but seems to be working. Hopefully that's good enough for now. I hate to invest too much time into files that are going to be radically changing soon.

Michelle

lainwired’s picture

I tested this on my test site and still no luck. Il wait and try the dev tomorrow before saying it didnt work though.

lainwired’s picture

This is my temporary fix

<'div class="content">
<'?php print $content ?>
<'/div>
<'/div>
<'br />
<'br />
<'br />
<'br />
<'br />
<'br />
<'br />
<'div class="clear">

<,div class="links">
<,?php print $links ?>

Lol not exactly a good fix but for the moment it looks better than without it. It will let me at least send it to my beta site and show off the new forum look to some users

lainwired’s picture

Actualy i modified it. The real fix is adding a <,div class="clear"> <,/div> around all the code to create the left part of the forum past. now the boxes are the right size. just wanted to let you guys know.

xerostatus’s picture

lainwired, can you elaborate your fix? I tried it the way democron shows, but it doesnt have any effect on my particular theme. Where did you add the code youre speaking of?

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.