Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are still @todos in core referring to #2109287: Replace list_themes() with a service.. That went in, they never got done.
Comment | File | Size | Author |
---|---|---|---|
#1 | list-themes-2188991-1.patch | 9.56 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThere are other places in OO code where list_themes() is used, that's an easy way to spot no unit test coverage.
Comment #2
amateescu CreditAttribution: amateescu commentedNice find! I hope the bot will agree with an early RTBC :)
Comment #3
sunLooks good.
That said, this patch introduces a new usage of $theme->filename which is an inane property that should (at least) be $uri, as I also discovered in #2188661: Extension System, Part II: ExtensionDiscovery, but I hope/assume that we'll be able to get rid of all of these bogus $filename instances in one go later on. (And for that, ->filename is most likely easier to grep than ->uri even ;))
Anyway, no reason to hold up this nice cleanup patch for that. :)
Comment #4
webchickCommitted and pushed to 8.x. Thanks!