Closed (fixed)
Project:
Panels
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Feb 2014 at 19:18 UTC
Updated:
1 Feb 2015 at 07:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
geek-merlinPatch flying in that fixes that for me.
Comment #2
damienmckennaI've ran into this in Panelizer too: #2246871: Body CSS classes not added when using Panels Everywhere
Thanks for the patch. This version adds a quick trim() around the two strings, just to make sure the output is clean.
Comment #3
juanjo_vlc commentedHi, I've the same issue, and got to the same conclusion, and very similar patch.
#2 Your trim is unnecessary, because it doesn't clear two consecutive whitespaces on the css string, and thus, explode will make empty values from them when removing classes, and submit function on panel editor must take care of it.
Comment #4
SGhosh commentedFor panels version '7.x-3.3', in case anybody comes looking for it -
PFA
Comment #6
damienmckennaComment #8
michelleIs this addressing the same bug as #2330413: body_classes_to_remove/body_classes_to_add not added correctly ? I reviewed that one just before coming to this one and that patch seems to fix the issue because both the site template body class and the custom page variant body class show up when that patch is applied.
Since Damien has a patch in both of these issues, I'm wondering if I'm missing something so I'm not going to change the status. It seems, though, that the other patch solves both problems. Could someone confirm/refute that?
Comment #9
damienmckennaClosed a duplicate: #2330413: body_classes_to_remove/body_classes_to_add not added correctly
Comment #11
damienmckennaComment #12
damienmckennaRTBC. Thanks juanjo_dv.
Comment #13
mrjmd commentedComment #14
japerryLooks good, committed!