The Drush project page gives instructions for manually installing Drush using a symbolic link, but if it's installed that way, run-tests-drush.sh fails to correctly get its real directory. The problem is easily fixed.

CommentFileSizeAuthor
#7 devel-symlinked-drush-2186691-7.patch636 bytesTravisCarden
#5 devel-symlinked-drush-2186691-5.patch373 bytesTravisCarden
#1 devel-symlinked-drush-2186691-1.patch376 bytesTravisCarden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented
Assigned: TravisCarden » Unassigned
Status: Active » Needs review
FileSize
devel-symlinked-drush-2186691-1.patch376 bytes

This oughta do the trick.

Status: Needs review » Needs work

The last submitted patch, 1: devel-symlinked-drush-2186691-1.patch, failed testing.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented
Status: Needs work » Needs review

It doesn't look like my patch caused the test failures. Can I just set the issue back to "Needs review" without re-invoking the testbot?

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Needs work

OSX readlink has no -m, at least for me.

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented
Status: Needs work » Needs review
FileSize
devel-symlinked-drush-2186691-5.patch373 bytes

D'oh! Well, maybe it's not necessary. It still does the job for me without it, and I forget now why I used it in the first place. :-P Does it work for you now?

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Needs work

Not working for me:

~/htd/d8/modules/devel (8.x-1.x *=)$ ./run-tests-drush.sh 
PHPUnit 3.7.16 by Sebastian Bergmann.

Cannot open file "./tests/drush_testcase.inc".
TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented
Status: Needs work » Needs review
FileSize
devel-symlinked-drush-2186691-7.patch636 bytes

Well, it's a horrible concession, but if realpath works for OSX then this gets the job done. (Attached.)

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Needs work

We figure out the path to drush in a few other places. Maybe we should be consistent?

drush/examples/example.bashrc
drush/drush.complete.sh

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented

example.bashrc doesn't look like it's cross-platform compatible, either. I wonder if Drush should expose this information itself so all the edge cases can be handled properly in one place. Something like drush core-status drush-path --format=list? I'd like to see that detail in core-status anyway. If you like that idea, @moshe weitzman, I'll create the issue against Drush.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

The point here is to find the path to Drush. You obviously can't depend on Drush to get that answer.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Version: 8.x-1.x-dev » 7.x-1.x-dev

This doesn't seems an issue anymore in the 8.x branch, since there is not a run-tests-drush.sh. Moving to 7.x

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs work » Closed (won't fix)

Lets not do this