#675446-238:

The Seven theme includes an override for jQuery UI's jquery.ui.theme.css. Hence in the backend, the autocomplete continues to look fine. However, in the front-end (Bartik), it looks like utter crap (i.e. jQuery UI's own jquery.ui.theme.css is used). This means that when you use in-place editing or an exposed Views filter that filters on tags… it's going to look like crap:

Seven
Bartik

CommentFileSizeAuthor
#29 Screen Shot 2023-01-12 at 11.42.17 am.png28.71 KBpameeela
#12 autocomplete-bartik.png12.39 KBtompagabor
#12 autocomplete-seven.png14.05 KBtompagabor
#6 interdiff.txt600 bytesKarmen
#6 drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-6.patch32.21 KBKarmen
#3 drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-2.patch32.21 KBKarmen
#1 drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-1.patch32.3 KBInternetDevels
#1 bartik.png13.54 KBInternetDevels
#1 seven.png8.96 KBInternetDevels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Active » Needs review
FileSize
seven.png8.96 KB
bartik.png13.54 KB
drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-1.patch32.3 KB
barraponto’s picture

barraponto CreditAttribution: barraponto commented
Status: Needs review » Needs work

I don't think we need filter:alpha since Internet Explorer 6, 7 and 8 are no longer supported. See https://drupal.org/node/1569578.

Karmen’s picture

Karmen CreditAttribution: Karmen commented
Status: Needs work » Needs review
FileSize
drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-2.patch32.21 KB

I just remove the filter for ie. It's ok?

Status: Needs review » Needs work

The last submitted patch, 3: drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-2.patch, failed testing.

Karmen’s picture

Karmen CreditAttribution: Karmen commented
Assigned: Unassigned » Karmen
Karmen’s picture

Karmen CreditAttribution: Karmen commented
Status: Needs work » Needs review
FileSize
drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-6.patch32.21 KB
interdiff.txt600 bytes

Add the new patch, with the interdiff. Sorry for the confusion.

Status: Needs review » Needs work

The last submitted patch, 6: drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-6.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented

6: drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-6.patch queued for re-testing.

Karmen’s picture

Karmen CreditAttribution: Karmen commented
Assigned: Karmen » Unassigned
Status: Needs work » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito commented
Issue tags: +frontend, +CSS

Tagging.

tompagabor queued 6: drupal_core-autocomplete_clean_up_jquery_ui_css_and_styles-2186649-6.patch for re-testing.

tompagabor’s picture

tompagabor CreditAttribution: tompagabor commented
Status: Needs review » Needs work
FileSize
autocomplete-seven.png14.05 KB
autocomplete-bartik.png12.39 KB

i tested it again.
Why we need, but why we need the ui icons? I didn't see any icons when tested the patch.

And there was some style changes, see attached screenshot, we need border on seven theme, and the dashed separator i don't think good choice for bartik.
Seven:

Bartik:

feonor’s picture

feonor CreditAttribution: feonor commented
Assigned: Unassigned » feonor
kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Issue summary: View changes

I can't reproduce it on my side with the last patch. Actually there was no jquery.ui.theme.css in sources of browser. All files from /core/themes/bartik/css was enabled except of jquery.ui.theme.css . I've tried to add this file and saw nothing. So https://www.drupal.org/node/2186649#comment-9122471 looks weird for me

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria at TES Global commented
Version: 8.0.x-dev » 8.2.x-dev
Component: CSS » Bartik theme
Assigned: feonor » Unassigned
Issue tags: +Usability

I'm moving this issue into the Bartik queue as the patch contains 100% Bartik files and I need to keep track of these things :-)

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Issue summary: View changes
Status: Needs work » Closed (cannot reproduce)
FileSize
Screen Shot 2023-01-12 at 11.42.17 am.png28.71 KB

The problems identified here are no longer reproducible, and the history of this and the related issue make this really confusing.

Current state of autocomplete in Bartik:

If folks think this needs improvement, we should create a new issue with the proposed changes.