We've been getting a bunch of bug reports that are PHP 5.5 only recently, for example:

#2155847: Panopoly panes error

We should start running our tests in PHP 5.5 as well!

(Not that our current Behat test suite would have caught that error in that case -- it doesn't load that page.)

I've given this a shot here:

https://travis-ci.org/lsolesen/panopoly/builds/17724794

CommentFileSizeAuthor
#7 panopoly-travis-php55-2183015.patch1.21 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

The PHP 5.5 tests passed! Not sure yet if I want to go forward with this yet, though... It does mean there are A LOT of builds on each commit. I'll think on it for a couple days.

lsolesen’s picture

lsolesen commented
Component: Code » Admin

Guessing that a couple of days has passed. Probably time for enabling the PHP5.5 tests?

Put out a new test run rebased on current head: https://travis-ci.org/lsolesen/panopoly/builds/50312387

lsolesen’s picture

lsolesen commented
Component: Admin » Tests / Continuous Integration
lsolesen’s picture

lsolesen commented
Status: Active » Needs review

Still passing!

lsolesen’s picture

lsolesen commented

Rebased on newest code https://travis-ci.org/lsolesen/panopoly/builds/63334408

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Active

On IRC, we discussed only running a single build with PHP 5.5, which @lsolesen figured out how to do:

https://github.com/lsolesen/panopoly/compare/5db61b4fa547...664f31e21b07

Assuming the build actually works, I'll include the same changes in upstream Panopoly!

Here's the build:

https://travis-ci.org/lsolesen/panopoly/builds/63339204

Marking as "Active" since there is no patch here.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly-travis-php55-2183015.patch1.21 KB

So, @lsolesen's tests failed because we're always setting up APC and there is no APC in PHP 5.5 or greater. Here's a patch which attempts to work around that.

lsolesen’s picture

lsolesen commented

Yeah, I saw that, and I was thinking around the same lines. APC should not be needed for PHP > 5.4 as I understand?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Yep! Any chance you could test the patch I posted? I haven't had a chance to run it on Travis yet.

lsolesen’s picture

lsolesen commented

I put it on Travis here: https://travis-ci.org/lsolesen/panopoly/builds/63614914

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: Run Travis-CI tests with PHP 5.5 as well » Run Travis-CI tests with PHP 5.5 and 5.6 as well
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

  • dsnopek committed 62582cb on 7.x-1.x 
    Issue #2183015 by dsnopek: Run Travis-CI tests with PHP 5.5 and 5.6 as...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Committed!

  • dsnopek committed 0f94afd on 7.x-1.x 
    Issue #2183015 by dsnopek: Update scripts/create_test_branch.py for the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.