Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The standard name for the minified version of the modernizr library is typically modernizr.min.js
(http://cdnjs.com/libraries/modernizr/). Is there any reason modernizr-min.js
was selected for this particular project? And could an additional check be added for the more traditional minified name?
Thanks!
Comment | File | Size | Author |
---|---|---|---|
#3 | 2182939.navbar_modernizr-filename-3.patch | 1.29 KB | eshta |
Comments
Comment #1
zxaos CreditAttribution: zxaos commented+1 to this issue from me.
This naming means that themes like circle which use either a CDN or a local libraries install of modernizr must load a second copy of it since the one installed for navbar cannot be used.
Comment #2
hass CreditAttribution: hass commentedI guess it was chosen for consistency with backdrop and underscore naming scheme.
I think it would be better to change to the common name modernizr.min.js.
Comment #3
eshta CreditAttribution: eshta at Acquia commentedLooks like Drupal 8 uses modernizr.min.js as well. I would agree with @hass that it was probably for consistency at the time. I think we should recognize the standard, though. I don't want to force the change, however, for existing users. The patch attached makes it so that navbar will look for either filename.
Comment #5
eshta CreditAttribution: eshta at Acquia commented