Both #2167641: EntityInterface::uri() should use route name and not path and #2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit are big huge patches that happen to need to add a proper title callback for the vocab's term overview page. In order to prevent further rerolling, let's just get this small change in first.

CommentFileSizeAuthor
#1 taxo-2181045-1.patch2 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new taxo-2181045-1.patch2 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch :). Nothing to review really so RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This isn't back from testbot yet, which is risky business, but was previously RTBC with zero failures from two different patches, and stops them both from trampling each other. Crossing fingers.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Needs work

The last submitted patch, 1: taxo-2181045-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Fixed

Thanks testbot :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.