Vocabulary::postSave should not load all field entities

You should never load all the fields, that's absolutely insane, there easily can be a thousand of them or more and the memory needed to load all would be sky high.

   $field_ids[] = $module . '.' . $field;

  public function id() {
    return $this->entity_type . '.' . $this->name;
  }

Hrm.

Right. The code is actually correct, just $module needs to be renamed to $entity_type, because that's what it is.

@chx: Note that field.module itself obviously has to load all field entities internally, to build this map. But agreed that user code should never do that.

Note: The propsed solution has the wrong field type (entity_term_reference, there is no such thing), but the implementation is correct :)

Renamed $module to $entity_type.

This looks good, thanks!

Committed cc618ea and pushed to 8.x. Thanks!