I am using the latest version of Bootstrap (3.0.3) and have the ability to change the number of columns from the default 12 to 16. In our sub-theme's variables.less file, I've changed the @grid-columns variable to '16' and changed the @grid-gutter-width from '30px' to '20px'.

When we did this, the navbar container was not lining up with edges of our main-container.

In overrides.less, the navbar container media queries hardcode the default @grid-gutter-width of 30px instead of using the variable.

// Default navbar.
.navbar.container {
  @media @tablet {
    max-width: ((@container-sm - 30px));
  }
  @media @normal {
    max-width: ((@container-md - 30px));
  }
  @media @wide {
    max-width: ((@container-lg - 30px));
  }

Instead of 30px, this should be @grid-gutter-width.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

trevorkjorlien’s picture

Attached patch to use @grid-gutter-width variable.

trevorkjorlien’s picture

Status: Active » Needs review
markhalliwell’s picture

Status: Needs review » Fixed

Thanks @trevorkjorlien!

Committed 919a729 to 7.x-3.x:

Issue #2178429 by trevorkjorlien: Navbar container media query in overrides.less not using @grid-gutter-width variable from variables.less.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ryan.armstrong’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev
Status: Closed (fixed) » Needs review

Moving this to the 8.x-3.x branch as it has been committed to that branch. Making sure the fix gets tested in the Drupal 8 release.

ryan.armstrong’s picture

markhalliwell’s picture

Version: 8.x-3.x-dev » 7.x-3.x-dev
Assigned: ryan.armstrong » Unassigned
Status: Needs review » Closed (fixed)

I'm just moving this back to 7.x. If this needs re-evaluation in 8.x, create a new issue.