Breadcrumb reactions fail for disabled menu items [#2177845]

When using reaction breadcrumb to point the trail at a disabled menu position the reaction is ignored.
Appears that the query specifically excludes hidden items for some reason.

In my use-case we add some items to our menus to just to control breadcrumbs (via Menu Breadcrumb) in concert with Context... even though we don't want to actually show that item in the rendered menu blocks.

Is there a reason not to remove this limit within the query?

Do we need to add an option to allow hidden menu items?

Happy to create a patch!

Comment	File	Size	Author
#3	breadcrumb_reactions_disabled_items-2177845-3.patch	2.33 KB	iamEAP
#3
#2	breadcrumb_reactions_disabled_items-2177845-2.patch	2.53 KB	doublejosh
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

doublejosh CreditAttribution: doublejosh commented 30 January 2014 at 00:37

Did some initial work on this, but it's pretty subtle!

For starters, context_reaction_breadcrumb is an extension of context_reaction_menu class. The option form does not break the menu item option out into a stand-alone item... meaning adding an "allow disabled" option breaks existing configurations. Certainly don't want to go moving settings around from where they exist in the form to where they are used as options.

Only reasonable plan is to make this a global setting to allow disabled menu items to control breadcrumbs.