Problem

  • Individual tests have access to the TestBase::$original* properties containing environment data of the parent site (test runner).
  • Tests must not have access to environment information of the test runner.

Proposed solution

  1. Introduce a new + single + central + private TestBase::$original (array/object) storage.

  2. Move all values being backed up in TestBase::prepareEnvironment() into TestBase::$original.

  3. Do something about Drupal\simpletest\BrokenSetUpTest (which relies on data sharing between parent/child site), or simply delete it.

CommentFileSizeAuthor
#15 test_classes_access_original_value-2177079-15.patch2.81 KBRevathi.B
#14 interdiff-2177079-09-12.txt1.28 KBzuhair_ak
#12 test_classes_access_original_values-2177079-12.patch2.27 KBzuhair_ak
#9 test-classes-can-access-original-values-2177079-09.patch1.25 KBjhedstrom
#9 interdiff.txt396 bytesjhedstrom
#5 test-classes-can-access-original-values-2177079-05.patch1.4 KBjhedstrom
#3 test-classes-can-access-original-values-2177079-03.patch0 bytesjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Assigned: Unassigned » sun
Issue summary: View changes
Priority: Normal » Major
Status: Active » Postponed
Issue tags: +Testing system
Related issues: +#2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead

I'll work on this, but postponing this on the following two issues:

#2170023: Use exceptions when something goes wrong in test setup
#2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead

Also, given that a malformed test is able to destroy the entire parent site by (un)intentionally accessing or changing those $original* variables, this is at least major.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Postponed » Active
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Active » Needs review
FileSize
test-classes-can-access-original-values-2177079-03.patch0 bytes

This just moves the existing properties that should not be accessible to private. Creating a central private and single property seems unnecessarily complex (and any sort of type hinting would be removed).

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Needs review » Needs work

Empty patch :(

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Status: Needs work » Needs review
FileSize
test-classes-can-access-original-values-2177079-05.patch1.4 KB

Empty patch :(

That's the easiest way to make testbot go green =)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Tests must not have access to environment information of the test runner.

Does anyone mind to update why?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented

re: #6 I think this comment from #1 is still relevant:

Also, given that a malformed test is able to destroy the entire parent site by (un)intentionally accessing or changing those $original* variables, this is at least major.

Status: Needs review » Needs work

The last submitted patch, 5: test-classes-can-access-original-values-2177079-05.patch, failed testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
interdiff.txt396 bytes
test-classes-can-access-original-values-2177079-09.patch1.25 KB

So BrokenSetupTest relies on TestBase::$originalFileDirectory, so switching that back to protected.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Needs review » Needs work

Applies cleanly to 8.1.x.

As a review: There are plenty of $original* properties which must have been added since the last time this issue was addressed. $originalContainer stands out. :-)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Zyxware Technologies commented
Assigned: sun » Unassigned
Status: Needs work » Needs review
FileSize
test_classes_access_original_values-2177079-12.patch2.27 KB

Changed all the $original* variables to private except TestBase::$originalFileDirectory ref #9.

Status: Needs review » Needs work

The last submitted patch, 12: test_classes_access_original_values-2177079-12.patch, failed testing.

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Zyxware Technologies commented
FileSize
interdiff-2177079-09-12.txt1.28 KB

I was naive enought to think that this patch will pass the test :| . Can someone point me in the direction where additional changes had to be made to make it work. I had forgotten to add the interdiff.txt above and have added now.

Revathi.B’s picture

Revathi.B CreditAttribution: Revathi.B commented
FileSize
test_classes_access_original_value-2177079-15.patch2.81 KB

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Component: simpletest.module » phpunit

Triaging issues in simpletest.module as part of the Bug Smash Initiative to determine if they should be in the Simpletest Project or core.

This looks like it a Phpunit issue, changing component.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.