The HTML produced by the module is broken. Div tag class attribute has no preceding space, and has extra spaces between equal sign.

Attached patch against 7-1.3

CommentFileSizeAuthor
#1 field_group-2175731.patch849 bytestobiasb
#1 field_group-7.x-1.3-2175731.patch784 bytestobiasb
field_group-html.patch886 bytesdaggerhart
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Version: 7.x-1.3 » 7.x-1.x-dev
FileSize
field_group-2175731.patch849 bytes
field_group-7.x-1.3-2175731.patch784 bytes

The patch fix the bug, but is wrong.

I added two patches which are for the current stable release (1.3) and current dev release. And I improved the fix.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Status: Active » Needs review
nedwardss’s picture

nedwardss CreditAttribution: nedwardss commented

This also can break JQuery as it can be finicky. I would like to up the priority but I don't think it's my place to. tobiasb patch looks good to me.

nedwardss’s picture

nedwardss CreditAttribution: nedwardss commented
Status: Needs review » Reviewed & tested by the community
nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop commented

Duplicate of #2129805
Will be released in a dev today.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Your dev patch has been committed. Thx :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jan.ptacek’s picture

jan.ptacek CreditAttribution: jan.ptacek commented

ops, just got bitten by this on a stable branch today - when do you plan a stable release, please?

  • Commit c477c67 on 7.x-1.x, 8.x-1.x authored by tobiasb, committed by zuuperman: 
    Issue #2175731 by tobiasb, daggerhart: HTML produced by module is broken...

The last submitted patch, 1: field_group-7.x-1.3-2175731.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 1: field_group-2175731.patch, failed testing.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop commented
Status: Needs work » Closed (fixed)